Skip to content

Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder #13926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Nov 2, 2020
Merged

Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder #13926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ dotnet_diagnostic.CA1828.severity = suggestion
dotnet_diagnostic.CA1829.severity = suggestion

# CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder
dotnet_diagnostic.CA1830.severity = suggestion
dotnet_diagnostic.CA1830.severity = warning

# CA1831: Use AsSpan or AsMemory instead of Range-based indexers when appropriate
dotnet_diagnostic.CA1831.severity = warning
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/FormatAndOutput/common/FormatViewManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ private static void ProcessUnknownViewName(TerminatingErrorContext errorContext,
{
// unKnowViewFormatStringBuilder.Append(StringUtil.Format(FormatAndOut_format_xxx.UnknownViewNameError, viewName));
unKnowViewFormatStringBuilder.Append(StringUtil.Format(FormatAndOut_format_xxx.UnknownViewNameErrorSuffix, viewName, formatTypeName));
unKnowViewFormatStringBuilder.Append(validViewFormats.ToString());
unKnowViewFormatStringBuilder.Append(validViewFormats);
}
else
{
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/ManagementObjectAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ internal static string GetMethodDefinition(MethodData mData)
builder.Append("System.Management.ManagementBaseObject ");
builder.Append(mData.Name);
builder.Append('(');
builder.Append(inParameterString.ToString());
builder.Append(inParameterString);
builder.Append(')');

string returnValue = builder.ToString();
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/ProxyCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ public static string GetHelpComments(PSObject help)
if (exsb.Length > 0)
{
sb.Append("\n\n.EXAMPLE\n\n");
sb.Append(exsb.ToString());
sb.Append(exsb);
}
}
}
Expand Down