Skip to content

Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder #13926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Nov 2, 2020
Merged

Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder #13926

iSazonov merged 1 commit into from
Nov 2, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 29, 2020

@xtqqczze xtqqczze marked this pull request as ready for review October 29, 2020 18:18
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 29, 2020

@iSazonov Can you approve?

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 30, 2020
@xtqqczze

This comment has been minimized.

Sign in to view
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 30, 2020

@iSazonov Please restart tests.

@iSazonov iSazonov closed this Oct 30, 2020
@iSazonov iSazonov reopened this Oct 30, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 30, 2020

Reopen the PR to restart all CIs.

@xtqqczze

This comment has been minimized.

Sign in to view
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 31, 2020

closing and reopening to restart tests

@xtqqczze xtqqczze closed this Oct 31, 2020
@xtqqczze xtqqczze reopened this Oct 31, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 1, 2020

@iSazonov Could you merge?

@iSazonov iSazonov assigned iSazonov and unassigned adityapatwardhan Nov 2, 2020
@iSazonov iSazonov merged commit 4b9f9dc into PowerShell:master Nov 2, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 2, 2020
@xtqqczze xtqqczze deleted the CA1830 branch November 2, 2020 03:49
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @adityapatwardhan