Enable CA1822: Mark private members as static #13897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtqqczze
changed the title
ghost
added
the
Waiting on Author
8 tasks
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
Collaborator
|
@xtqqczze Please split the PR. |
This was referenced Nov 23, 2020
xtqqczze
added a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Nov 23, 2020
src\System.Management.Automation\engine\remoting\ _Contributes to PowerShell#13897._ https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
xtqqczze
added a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Nov 23, 2020
`src\System.Management.Automation\engine\` -`src\System.Management.Automation\engine\remoting\` _Contributes to PowerShell#13897._ https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
xtqqczze
added a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Nov 23, 2020
`src\System.Management.Automation\` -`src\System.Management.Automation\engine\` Contributes to PowerShell#13897. https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
Contributor
Author
Split is completed. |
ghost
added
Waiting on Author
xtqqczze
changed the title
ghost
removed
the
Waiting on Author
xtqqczze
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
Contributor
Author
|
@iSazonov Please could you review. |
iSazonov
reviewed
Dec 7, 2020
iSazonov
added
the
CL-CodeCleanup
xtqqczze
changed the title
iSazonov
approved these changes
Dec 7, 2020
Contributor
Author
iSazonov
reviewed
Dec 9, 2020
rjmholt
approved these changes
Dec 9, 2020
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
Non-breaking change as only enabled for non-public API surface.