Skip to content

Enable IDE0048: AddRequiredParentheses #13896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Oct 29, 2020
Merged

Enable IDE0048: AddRequiredParentheses #13896

iSazonov merged 1 commit into from
Oct 29, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 26, 2020

@xtqqczze xtqqczze marked this pull request as ready for review October 27, 2020 15:06
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 29, 2020

Default is always_for_clarity for arithmetic, relational, and other binary operators.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 29, 2020
@iSazonov iSazonov merged commit 83a3f53 into PowerShell:master Oct 29, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Oct 29, 2020
@xtqqczze xtqqczze deleted the IDE0048 branch October 29, 2020 14:25
@xtqqczze xtqqczze mentioned this pull request Oct 29, 2020
Closed
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 29, 2020

This PR did not fix all IDE0048 violations, see #13936. Since the severity was set to warning, the build should not have completed!

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 30, 2020

Is it a bug in the Roslyn analyzer?

@xtqqczze xtqqczze restored the IDE0048 branch October 30, 2020 14:07
@xtqqczze xtqqczze deleted the IDE0048 branch November 2, 2020 03:51
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 2, 2020

Is it a bug in the Roslyn analyzer?

No EnforceCodeStyleInBuild was not enabled.

@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @adityapatwardhan