Skip to content

Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable #13878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Oct 30, 2020
Merged

Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable #13878

iSazonov merged 1 commit into from
Oct 30, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 26, 2020 •
edited
Loading

@ghost ghost assigned iSazonov Oct 26, 2020
@xtqqczze xtqqczze changed the title CA1834: Consider using 'StringBuilder.Append(char)' when applicable Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable Oct 26, 2020
@xtqqczze xtqqczze marked this pull request as ready for review October 26, 2020 17:01
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 26, 2020

No new CodeFactor issues.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 26, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 27, 2020

@iSazonov SSH-Tests Failing after 60m — Build #PR-13878-20201026.01 failed, please restart

@iSazonov iSazonov merged commit af8558b into PowerShell:master Oct 30, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Oct 30, 2020
@xtqqczze xtqqczze deleted the CA1834 branch October 30, 2020 14:50
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov