Skip to content

Enable CA1068: CancellationToken parameters must come last #13867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Nov 5, 2020
Merged

Enable CA1068: CancellationToken parameters must come last #13867

iSazonov merged 2 commits into from
Nov 5, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 25, 2020 •
edited
Loading

@xtqqczze xtqqczze marked this pull request as ready for review October 27, 2020 20:43
@xtqqczze xtqqczze changed the title Enable CA1068: CancellationToken parameters must come last WIP: Enable CA1068: CancellationToken parameters must come last Oct 27, 2020
@xtqqczze xtqqczze changed the title WIP: Enable CA1068: CancellationToken parameters must come last Enable CA1068: CancellationToken parameters must come last Oct 28, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 29, 2020
@iSazonov iSazonov assigned iSazonov and unassigned adityapatwardhan Nov 5, 2020
@iSazonov iSazonov merged commit 47c9209 into PowerShell:master Nov 5, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 5, 2020
@xtqqczze xtqqczze deleted the CA1068 branch November 5, 2020 16:35
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @adityapatwardhan