Skip to content

Conversation

@krishnayalavarthi
Copy link
Contributor

@krishnayalavarthi krishnayalavarthi commented Oct 22, 2020

PR Summary

TranscriptionOption.Dispose() should be idempotent #13830

PR Context

TranscriptionOption.Dispose() should be idempotent #13830

PR Checklist

@ghost ghost assigned TravisEz13 Oct 22, 2020
@PaulHigin PaulHigin self-requested a review October 22, 2020 23:27
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13
Copy link
Member

@PoshChan Please remind me in 1 hour

@TravisEz13 TravisEz13 changed the title Transcription issue Make dispose in TranscriptionOption idempotent Oct 23, 2020
@TravisEz13 TravisEz13 merged commit c8feddb into PowerShell:master Oct 23, 2020
@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 1 hour ago

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 16, 2020
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants