fix(utility): nullable formatting #13800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
|
iSazonov
reviewed
Oct 17, 2020
| { | ||
| if (_autosize.HasValue) | ||
| return _autosize.Value; | ||
| return _autosize; |
Collaborator
There was a problem hiding this comment.
We can not assign nullable type to non-nullable one.
Below too.
Suggested change
| return _autosize; | |
| return _autosize.GetValueOrDefault(); |
Collaborator
There was a problem hiding this comment.
You should do the same for rest of changes. See compilation errors.
As this is done on a machine with no formatting, I need to rely on the developer on the other end to verify the code Co-authored-by: Ilya <darpa@yandex.ru>
Contributor
Author
|
Conversion issues here aswell, will be fixed tomorrow hopefully |
Contributor
Author
|
cancelling as I think someone else is doing these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #13793
related to #13791