Change Nullable usage #13793
Merged
Change Nullable usage #13793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed format of nullable usage to one more appropriate
ghost
assigned
iSazonov
reviewed
Oct 16, 2020
src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImplicitRemotingCommands.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
georgettica
changed the title
Contributor
Author
|
Not sure why this fails, is there a way to retrigger the tests? |
Collaborator
|
Restarted Windows CI. |
Contributor
Author
|
@iSazonov, seems the checks passed can you approve this PR so I can continue? |
iSazonov
approved these changes
Oct 17, 2020
This was referenced Oct 17, 2020
Closed
iSazonov
added
CL-CodeCleanup
daxian-dbw
reviewed
Nov 16, 2020
| if (secondsRemaining.HasValue && secondsRemaining.Value == 0 && | ||
| percentComplete.HasValue && percentComplete.Value == 100) | ||
| if (secondsRemaining.HasValue && secondsRemaining.GetValueOrDefault() == 0 && | ||
| percentComplete.HasValue && percentComplete.GetValueOrDefault() == 100) |
Member
There was a problem hiding this comment.
@iSazonov I don't understand this change. HasValue check has been done, so it's fine to directly use .Value, isn't it?
daxian-dbw
added a commit
that referenced
this pull request
Nov 18, 2020
This reverts commit 2e0b51d.
iSazonov
pushed a commit
that referenced
this pull request
Nov 19, 2020
iSazonov
added
CL-NotInBuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
changed format of nullable usage to one more appropriate
PR Context
related to #13791
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.