Skip to content

Conversation

@rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Oct 13, 2020

Fixes #13462.

The token entries in PSParser are out of date and need to be updated.

We should continue tracking work after this PR is merged to test this API to prevent future regressions.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Oct 13, 2020
@rjmholt rjmholt changed the title Add missing token entries Add missing PSToken entries Oct 13, 2020
@iSazonov
Copy link
Collaborator

As for test, we could add temporary internal static method to check a consistency of s_tokenKindMapping and other static mappings in xUnit test.

@daxian-dbw daxian-dbw merged commit 56ad41b into PowerShell:master Oct 14, 2020
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Oct 14, 2020
@daxian-dbw daxian-dbw added this to the 7.1.0-RC.2 milestone Oct 14, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

🎉v7.1.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.1.x-Done Backport to 7.1.x completed CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PSParser Tokenize with Switch Default fails

5 participants