Skip to content

Update pwsh -? output to match docs #13748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 4 commits into from
Nov 4, 2020
Merged

Update pwsh -? output to match docs #13748

anmenaga merged 4 commits into from
Nov 4, 2020

Conversation

@sdwheeler
Copy link
Collaborator

@sdwheeler sdwheeler commented Oct 5, 2020 •
edited
Loading

PR Summary

Updates pwsh -? output to match docs. Related to:

PR Context

Incorporated feedback from @mklement0 and added docs for -sshs parameter.

PR Checklist

@ghost ghost assigned anmenaga Oct 5, 2020
@sdwheeler sdwheeler mentioned this pull request Oct 5, 2020
Merged
23 tasks
SteveL-MSFT
SteveL-MSFT requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the overall changes, but they really should have been in a separate PR to make review easier. No need to split it this time.

src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx Outdated
$env:PSExecutionPolicyPreference environment variable does not exist on
non-Windows platforms.

-InputFormat | -in | -if
Copy link
Member

@SteveL-MSFT SteveL-MSFT Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per

PowerShell/src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs

Line 897 in 3b83a68

else if (MatchSwitch(switchKey, "inputformat", "inp") || MatchSwitch(switchKey, "if", "if"))
this should be -inp

Copy link
Collaborator Author

@sdwheeler sdwheeler Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx Outdated

-SSHServerMode | -sshs

Used for running PowerShell as an SSH subsystem. It is not intended or
Copy link
Member

@SteveL-MSFT SteveL-MSFT Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it a bit more specific? Like:

Used in sshd_config for running PowerShell as an SSH subsystem.

Copy link
Collaborator Author

@sdwheeler sdwheeler Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 6, 2020
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 6, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 6, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 13, 2020
@ghost
Copy link

ghost commented Oct 13, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

SteveL-MSFT
SteveL-MSFT approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

@sdwheeler @SteveL-MSFT
Update src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntrance…
ce40ae1 
…Strings.resx

Co-authored-by: Steve Lee <slee@microsoft.com>
daxian-dbw
daxian-dbw approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion: move [-Version] to the next line to make the lines more aligned.

@sdwheeler @daxian-dbw
Update src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntrance…
0e3a384 
…Strings.resx

Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@anmenaga
Copy link

anmenaga commented Nov 4, 2020

CI failures are in unrelated Get-Counter CounterSet tests. Restarted.

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 4, 2020
@anmenaga anmenaga merged commit beb074d into PowerShell:master Nov 4, 2020
@adityapatwardhan adityapatwardhan added this to the 7.1.0 milestone Nov 4, 2020
@adityapatwardhan adityapatwardhan added BackPort-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.1.x-Approved labels Nov 6, 2020
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Nov 10, 2020
@sdwheeler @adityapatwardhan
Update pwsh -? output to match docs (PowerShell#13748)
745d1c4
@ghost
Copy link

ghost commented Nov 11, 2020

🎉v7.1.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

iSazonov
iSazonov reviewed Jan 18, 2021
View reviewed changes
src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx
Comment on lines +390 to +392
Does not present an interactive prompt to the user. Any attempts to use
interactive features, like Read-Host or confirmation prompts, result in
statement-terminating errors.
Copy link
Collaborator

@iSazonov iSazonov Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web docs was not updated.

@unfurl-links unfurl-links bot mentioned this pull request Jan 18, 2021
Closed
@sdwheeler sdwheeler deleted the sdw-6548-6702 branch March 20, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

+1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

BackPort-7.1.x-Done Backport to 7.1.x completed CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

@sdwheeler @anmenaga @daxian-dbw @rjmholt @SteveL-MSFT @iSazonov @adityapatwardhan