Skip to content

Avoid an exception if file system does not support reparse points #13634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjmholt merged 6 commits into from
Dec 3, 2020
Merged

Avoid an exception if file system does not support reparse points #13634

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2165190
Avoid an exception if file system does not support reparse points
iSazonov Sep 15, 2020
c4125eb
Fast return if it is not reparse point
iSazonov Oct 8, 2020
f9c50d6
Remove unused consts
iSazonov Oct 8, 2020
1f400c0
Update src/System.Management.Automation/namespaces/FileSystemProvider.cs
iSazonov Oct 9, 2020
ad6996d
Update src/System.Management.Automation/namespaces/FileSystemProvider.cs
iSazonov Oct 9, 2020
9f5ef42
Fix hardlink detection
iSazonov Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions src/System.Management.Automation/namespaces/FileSystemProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7840,8 +7840,6 @@ public static class InternalSymbolicLinkLinkCodeMethods
// data is 16KB, plus there's a header.
private const int MAX_REPARSE_SIZE = (16 * 1024) + REPARSE_GUID_DATA_BUFFER_HEADER_SIZE;

private const int ERROR_NOT_A_REPARSE_POINT = 4390;

private const int FSCTL_GET_REPARSE_POINT = 0x000900A8;

private const int FSCTL_SET_REPARSE_POINT = 0x000900A4;
Expand Down Expand Up @@ -8156,16 +8154,20 @@ private static string WinInternalGetLinkType(string filePath)
// Get Buffer size
IntPtr dangerousHandle = handle.DangerousGetHandle();

bool result = DeviceIoControl(dangerousHandle, FSCTL_GET_REPARSE_POINT,
IntPtr.Zero, 0, outBuffer, outBufferSize, out bytesReturned, IntPtr.Zero);
bool result = DeviceIoControl(
dangerousHandle,
FSCTL_GET_REPARSE_POINT,
InBuffer: IntPtr.Zero,
nInBufferSize: 0,
outBuffer,
outBufferSize,
out bytesReturned,
lpOverlapped: IntPtr.Zero);

if (!result)
{
int lastError = Marshal.GetLastWin32Error();
if (lastError == ERROR_NOT_A_REPARSE_POINT)
linkType = null;
else
throw new Win32Exception(lastError);
// It's not a reparse point or the file system doesn't support reparse points.
return IsHardLink(ref dangerousHandle) ? "HardLink" : null;
}

REPARSE_DATA_BUFFER_SYMBOLICLINK reparseDataBuffer = Marshal.PtrToStructure<REPARSE_DATA_BUFFER_SYMBOLICLINK>(outBuffer);
Expand All @@ -8185,7 +8187,7 @@ private static string WinInternalGetLinkType(string filePath)
break;

default:
linkType = IsHardLink(ref dangerousHandle) ? "HardLink" : null;
linkType = null;
break;
}

Expand Down Expand Up @@ -8402,16 +8404,20 @@ private static string WinInternalGetTarget(SafeFileHandle handle)
// According to MSDN guidance DangerousAddRef() and DangerousRelease() have been used.
handle.DangerousAddRef(ref success);

bool result = DeviceIoControl(handle.DangerousGetHandle(), FSCTL_GET_REPARSE_POINT,
IntPtr.Zero, 0, outBuffer, outBufferSize, out bytesReturned, IntPtr.Zero);
bool result = DeviceIoControl(
handle.DangerousGetHandle(),
FSCTL_GET_REPARSE_POINT,
InBuffer: IntPtr.Zero,
nInBufferSize: 0,
outBuffer,
outBufferSize,
out bytesReturned,
lpOverlapped: IntPtr.Zero);

if (!result)
{
int lastError = Marshal.GetLastWin32Error();
if (lastError == ERROR_NOT_A_REPARSE_POINT)
return null;

throw new Win32Exception(lastError);
// It's not a reparse point or the file system doesn't support reparse points.
return null;
}

string targetDir = null;
Expand Down