Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Sep 4, 2020

PR Summary

PR Context

PR Checklist

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Sep 4, 2020

@iSazonov Should I fix Codacy issues, "Remove the type specification; it is redundant." (I am not sure this would aid readability)

@iSazonov
Copy link
Collaborator

iSazonov commented Sep 5, 2020

Should I fix Codacy issues, "Remove the type specification; it is redundant." (I am not sure this would aid readability)

No. It looks as false positive and does not add readability.

@ghost ghost added the Review - Needed The PR is being reviewed label Sep 18, 2020
@ghost
Copy link

ghost commented Sep 18, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

@iSazonov Is master currently open for merging?

@iSazonov
Copy link
Collaborator

@xtqqczze I can ask MSFT team there PowerShell/PowerShell-RFC#263 :-)

@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 12, 2020
@SteveL-MSFT
Copy link
Member

@iSazonov yes, master branch should now be 7.2

@xtqqczze
Copy link
Contributor Author

@SteveL-MSFT Please could you review or add review needed tag.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 20, 2020
@ghost
Copy link

ghost commented Oct 20, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Nov 5, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 5, 2020

@xtqqczze Please resolve merge conflicts and add references to rule docs in the PR description.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 5, 2020

@xtqqczze Please resolve merge conflicts and add references to rule docs in the PR description.

@iSazonov Done.

@iSazonov iSazonov merged commit d6727dc into PowerShell:master Nov 5, 2020
@xtqqczze xtqqczze deleted the RCS1048 branch November 5, 2020 17:55
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants