Enable IDE0031: Null check can be simplified #13548

xtqqczze · 2020-08-30T23:05:38Z

PR Summary

Use C# 6.0 null propagation:

(result == null) ? null : result.Instance -> result?.Instance
(result != null) ? result.Instance : null -> result?.Instance

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0031

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- [NA] Experimental feature(s) needed
  - [NA] Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- [NA] Documentation needed
  - [NA] Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- [NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

iSazonov · 2020-08-31T15:40:57Z

My personal feeling is that it doesn't add to readability. I would prefer that we move the CodeFactor index to the green area.

ghost · 2020-09-09T14:00:11Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

daxian-dbw · 2020-09-15T21:16:17Z

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it. But please delay merging the PR until after the 7.1.0-RC.1 release branch is created.

iSazonov · 2020-09-16T13:59:18Z

Convert to draft until 7.1 RC1.

ghost · 2020-10-04T20:00:07Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

xtqqczze · 2020-10-13T00:02:52Z

needs triage

ghost · 2020-10-20T14:00:12Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

xtqqczze · 2020-10-21T13:19:48Z

updated PR description

xtqqczze · 2020-10-21T13:31:01Z

@daxian-dbw Can you review?

xtqqczze · 2020-10-22T17:00:38Z

rebased

TravisEz13

reviewed 13/42

TravisEz13 · 2020-10-25T16:27:45Z

@PoshChan Please remind me in 7 days

ghost · 2020-11-03T02:00:07Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

iSazonov · 2020-11-05T04:42:36Z

@xtqqczze Please resolve merge conflicts.

xtqqczze · 2020-11-05T16:57:53Z

Resolved merge conflicts.

iSazonov · 2020-11-05T17:33:22Z

@TravisEz13 Do you want to continue the code review?

ghost · 2020-11-13T02:00:06Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

ghost · 2020-12-15T21:32:50Z

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

xtqqczze requested review from adityapatwardhan and daxian-dbw as code owners August 30, 2020 23:05

ghost assigned iSazonov Aug 30, 2020

iSazonov added the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 2, 2020

ghost added the Review - Needed The PR is being reviewed label Sep 9, 2020

ghost removed the Review - Needed The PR is being reviewed label Sep 15, 2020

daxian-dbw removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 15, 2020

iSazonov marked this pull request as draft September 16, 2020 13:58

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 19, 2020

ghost added the Stale label Oct 4, 2020

xtqqczze marked this pull request as ready for review October 13, 2020 00:01

ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Oct 13, 2020

iSazonov approved these changes Oct 13, 2020

View reviewed changes

ghost added the Review - Needed The PR is being reviewed label Oct 20, 2020

iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 21, 2020

Fix IDE0031: Null check can be simplified

de2ddbb

xtqqczze force-pushed the IDE0031 branch from c3ccc0a to de2ddbb Compare October 22, 2020 17:00

TravisEz13 reviewed Oct 25, 2020

View reviewed changes

ghost removed the Review - Needed The PR is being reviewed label Oct 25, 2020

xtqqczze added 2 commits October 26, 2020 16:39

Merge branch 'master' into IDE0031

d5044cf

Set IDE0031 to warning

6296b7e

xtqqczze changed the title ~~Fix IDE0031: Null check can be simplified~~ Enable IDE0031: Null check can be simplified Oct 26, 2020

ghost added the Review - Needed The PR is being reviewed label Nov 3, 2020

ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020

Merge branch 'master' into IDE0031

6e42b09

ghost added the Review - Needed The PR is being reviewed label Nov 13, 2020

iSazonov merged commit 9e28529 into PowerShell:master Nov 20, 2020

ghost removed the Review - Needed The PR is being reviewed label Nov 20, 2020

iSazonov added this to the 7.2.0-preview.2 milestone Nov 20, 2020

xtqqczze deleted the IDE0031 branch November 20, 2020 08:41

Enable IDE0031: Null check can be simplified #13548

Enable IDE0031: Null check can be simplified #13548

Uh oh!

Conversation

xtqqczze commented Aug 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

iSazonov commented Aug 31, 2020

Uh oh!

ghost commented Sep 9, 2020

Uh oh!

daxian-dbw commented Sep 15, 2020

Uh oh!

iSazonov commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 4, 2020

Uh oh!

xtqqczze commented Oct 13, 2020

Uh oh!

ghost commented Oct 20, 2020

Uh oh!

xtqqczze commented Oct 21, 2020

Uh oh!

xtqqczze commented Oct 21, 2020

Uh oh!

xtqqczze commented Oct 22, 2020

Uh oh!

TravisEz13 left a comment

Choose a reason for hiding this comment

Uh oh!

TravisEz13 commented Oct 25, 2020

Uh oh!

ghost commented Nov 3, 2020

Uh oh!

iSazonov commented Nov 5, 2020

Uh oh!

xtqqczze commented Nov 5, 2020

Uh oh!

iSazonov commented Nov 5, 2020

Uh oh!

ghost commented Nov 13, 2020

Uh oh!

ghost commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xtqqczze commented Aug 30, 2020 •

edited

Loading

iSazonov commented Sep 16, 2020 •

edited

Loading