Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 28, 2020

PR Summary

  • Replace magic number: 0 with PdhResults.PDH_CSTATUS_VALID_DATA
  • Remove useless assignments (fix Codacy issues)

https://docs.microsoft.com/en-us/windows/win32/perfctrs/checking-pdh-interface-return-values

Best approach to review is commit by commit.

PR Context

Follow-up #13502

PR Checklist

@xtqqczze xtqqczze changed the title Replace magic number with constant Replace magic number with constant in PDH Aug 28, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 29, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 5, 2020
@ghost
Copy link

ghost commented Sep 5, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Nov 5, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov iSazonov merged commit 45ffc2c into PowerShell:master Nov 5, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 5, 2020
@xtqqczze xtqqczze deleted the use-uint-pdh2 branch November 5, 2020 16:22
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants