Skip to content

Change PSManageBreakpointsInRunspace to be non-Experimental #13527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SteveL-MSFT wants to merge 2 commits into from
Closed

Change PSManageBreakpointsInRunspace to be non-Experimental #13527

SteveL-MSFT wants to merge 2 commits into from

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Aug 26, 2020 •
edited
Loading

PR Summary

Remove code that made this an Experimental Feature and updated tests.

PR Context

@PowerShell/powershell-committee agreed to take this feature out of Experimental: #13406

PR Checklist

@ghost ghost assigned anmenaga Aug 26, 2020
@SteveL-MSFT SteveL-MSFT mentioned this pull request Aug 26, 2020
Closed
@SteveL-MSFT SteveL-MSFT force-pushed the psmanagebreakpointsinrunspace branch from ede98ad to 29090f9 Compare August 27, 2020 05:23
@daxian-dbw
Copy link
Member

daxian-dbw commented Aug 27, 2020

@SteveL-MSFT please rebase your branch.

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Aug 27, 2020

I'm not sure I feel comfortable with moving this out of experimental in light of some of the odd behavior Justin was seeing in his codespaces demo which happened with PowerShell 7 console debugging.

@SteveL-MSFT SteveL-MSFT force-pushed the psmanagebreakpointsinrunspace branch from 29090f9 to d63a894 Compare August 27, 2020 23:43
@SteveL-MSFT SteveL-MSFT added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Aug 28, 2020
@anmenaga
Copy link

anmenaga commented Sep 1, 2020

@SteveL-MSFT Is PowerShell-CI-windows failing expected?

@daxian-dbw
Copy link
Member

daxian-dbw commented Sep 2, 2020 •
edited
Loading

@TylerLeonhardt Can you please open an issue to describe and track the odd behavior you and Justin observed?

@TylerLeonhardt TylerLeonhardt mentioned this pull request Sep 3, 2020
Closed
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Sep 3, 2020

@daxian-dbw I've opened this issue: #13567 the gist is, we (probably I) broke the behavior way back for PS7. We probably shouldn't have a -BreakAll on Debug-Runspace but rather a NoBreakAll or similar to maintain backcompat.

@SteveL-MSFT SteveL-MSFT marked this pull request as draft September 3, 2020 20:01
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Sep 3, 2020

This is pending investigation of other debugger issues that may or may not be related to this experimental feature

@SteveL-MSFT SteveL-MSFT removed the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Sep 30, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 3, 2020
@ghost ghost added the Stale label Oct 18, 2020
@ghost
Copy link

ghost commented Oct 18, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Oct 29, 2020
@SteveL-MSFT SteveL-MSFT added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jul 21, 2021
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Jul 21, 2021
@SteveL-MSFT SteveL-MSFT reopened this Jul 21, 2021
@SteveL-MSFT SteveL-MSFT requested a review from PaulHigin July 21, 2021 20:30
PaulHigin
PaulHigin approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can address any issues as they arise.

@SteveL-MSFT SteveL-MSFT marked this pull request as ready for review July 28, 2021 16:25
@SteveL-MSFT SteveL-MSFT force-pushed the psmanagebreakpointsinrunspace branch from d63a894 to 7577290 Compare July 28, 2021 16:29
@SteveL-MSFT SteveL-MSFT removed the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jul 28, 2021
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jul 28, 2021

Reassinging as Andrew is out right now

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jul 28, 2021

Re-running CI tests

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 5, 2021
@ghost
Copy link

ghost commented Aug 5, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Aug 16, 2021

Fixed via #15864

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 16, 2021
@SteveL-MSFT SteveL-MSFT deleted the psmanagebreakpointsinrunspace branch August 16, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SteveL-MSFT @daxian-dbw @TylerLeonhardt @anmenaga @adityapatwardhan @PaulHigin