Skip to content

Members of internal types should not be public #13436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xtqqczze wants to merge 4 commits into from
Closed

Members of internal types should not be public #13436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daba370
Members of internal types should not be public
xtqqczze Aug 14, 2020
1a3b9eb
Fix error CS0507
xtqqczze Aug 14, 2020
e67787a
Fix error CS0273
xtqqczze Aug 14, 2020
aed8616
Fix error CS0279
xtqqczze Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimAsyncOperation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ internal abstract class CimAsyncOperation : IDisposable
/// <summary>
/// The constructor.
/// </summary>
public CimAsyncOperation()
internal CimAsyncOperation()
{
this.moreActionEvent = new ManualResetEventSlim(false);
this.actionQueue = new ConcurrentQueue<CimBaseAction>();
Expand Down Expand Up @@ -128,7 +128,7 @@ protected void OperationDeletedHandler(object cimSession, OperationEventArgs act
/// <param name="cmdletOperation">
/// Wrapper of cmdlet, <seealso cref="CmdletOperationBase"/> for details.
/// </param>
public void ProcessActions(CmdletOperationBase cmdletOperation)
internal void ProcessActions(CmdletOperationBase cmdletOperation)
{
if (!this.actionQueue.IsEmpty)
{
Expand All @@ -153,7 +153,7 @@ public void ProcessActions(CmdletOperationBase cmdletOperation)
/// <param name="cmdletOperation">
/// Wrapper of cmdlet, <seealso cref="CmdletOperationBase"/> for details.
/// </param>
public void ProcessRemainActions(CmdletOperationBase cmdletOperation)
internal void ProcessRemainActions(CmdletOperationBase cmdletOperation)
{
DebugHelper.WriteLogEx();

Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimBaseAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ internal abstract class CimBaseAction
/// <summary>
/// Constructor method.
/// </summary>
public CimBaseAction()
internal CimBaseAction()
{
}

Expand All @@ -32,7 +32,7 @@ public CimBaseAction()
/// cmdlet wrapper object, to which write result.
/// <see cref="CmdletOperationBase"/> for details.
/// </param>
public virtual void Execute(CmdletOperationBase cmdlet)
internal virtual void Execute(CmdletOperationBase cmdlet)
{
}

Expand Down Expand Up @@ -71,7 +71,7 @@ internal class CimSyncAction : CimBaseAction, IDisposable
/// <summary>
/// The constructor.
/// </summary>
public CimSyncAction()
internal CimSyncAction()
{
this.completeEvent = new ManualResetEventSlim(false);
this.responseType = CimResponseType.None;
Expand All @@ -83,7 +83,7 @@ public CimSyncAction()
/// </para>
/// </summary>
/// <returns>Response from user.</returns>
public virtual CimResponseType GetResponse()
internal virtual CimResponseType GetResponse()
{
this.Block();
return responseType;
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetAssociatedInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ internal sealed class CimGetAssociatedInstance : CimAsyncOperation
/// Constructor
/// </para>
/// </summary>
public CimGetAssociatedInstance()
internal CimGetAssociatedInstance()
: base()
{
}
Expand All @@ -34,7 +34,7 @@ public CimGetAssociatedInstance()
/// </para>
/// </summary>
/// <param name="cmdlet"><see cref="GetCimInstanceCommand"/> object.</param>
public void GetCimAssociatedInstance(GetCimAssociatedInstanceCommand cmdlet)
internal void GetCimAssociatedInstance(GetCimAssociatedInstanceCommand cmdlet)
{
IEnumerable<string> computerNames = ConstValue.GetComputerNames(cmdlet.ComputerName);
// use the namespace from parameter
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetCimClass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ internal CimGetCimClassContext(
/// Wildcard expansion should be allowed.
/// </para>
/// </summary>
public string ClassName
internal string ClassName
{
get { return className; }

Expand Down Expand Up @@ -111,7 +111,7 @@ internal sealed class CimGetCimClass : CimAsyncOperation
/// Constructor
/// </para>
/// </summary>
public CimGetCimClass()
internal CimGetCimClass()
: base()
{
}
Expand All @@ -122,7 +122,7 @@ public CimGetCimClass()
/// </para>
/// </summary>
/// <param name="cmdlet"><see cref="GetCimClassCommand"/> object.</param>
public void GetCimClass(GetCimClassCommand cmdlet)
internal void GetCimClass(GetCimClassCommand cmdlet)
{
List<CimSessionProxy> proxys = new List<CimSessionProxy>();
string nameSpace = ConstValue.GetNamespace(cmdlet.Namespace);
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimGetInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ internal class CimGetInstance : CimAsyncOperation
/// Constructor
/// </para>
/// </summary>
public CimGetInstance() : base()
internal CimGetInstance() : base()
{
}

Expand All @@ -67,7 +67,7 @@ public CimGetInstance() : base()
/// </para>
/// </summary>
/// <param name="cmdlet"><see cref="GetCimInstanceCommand"/> object.</param>
public void GetCimInstance(GetCimInstanceCommand cmdlet)
internal void GetCimInstance(GetCimInstanceCommand cmdlet)
{
GetCimInstanceInternal(cmdlet);
}
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimInvokeCimMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ internal CimMethodParametersCollection ParametersCollection
/// Constructor
/// </para>
/// </summary>
public CimInvokeCimMethod()
internal CimInvokeCimMethod()
: base()
{
}
Expand All @@ -89,7 +89,7 @@ public CimInvokeCimMethod()
/// </para>
/// </summary>
/// <param name="cmdlet"><see cref="GetCimInstanceCommand"/> object.</param>
public void InvokeCimMethod(InvokeCimMethodCommand cmdlet)
internal void InvokeCimMethod(InvokeCimMethodCommand cmdlet)
{
IEnumerable<string> computerNames = ConstValue.GetComputerNames(cmdlet.ComputerName);
string nameSpace;
Expand Down Expand Up @@ -246,7 +246,7 @@ public void InvokeCimMethod(InvokeCimMethodCommand cmdlet)
/// </para>
/// </summary>
/// <param name="cimInstance"></param>
public void InvokeCimMethodOnCimInstance(CimInstance cimInstance, XOperationContextBase context, CmdletOperationBase operation)
internal void InvokeCimMethodOnCimInstance(CimInstance cimInstance, XOperationContextBase context, CmdletOperationBase operation)
{
DebugHelper.WriteLogEx();
CimInvokeCimMethodContext cimInvokeCimMethodContext = context as CimInvokeCimMethodContext;
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimNewCimInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ internal sealed class CimNewCimInstance : CimAsyncOperation
/// Constructor
/// </para>
/// </summary>
public CimNewCimInstance()
internal CimNewCimInstance()
: base()
{
}
Expand All @@ -60,7 +60,7 @@ public CimNewCimInstance()
/// </para>
/// </summary>
/// <param name="cmdlet"><see cref="GetCimInstanceCommand"/> object.</param>
public void NewCimInstance(NewCimInstanceCommand cmdlet)
internal void NewCimInstance(NewCimInstanceCommand cmdlet)
{
DebugHelper.WriteLogEx();

Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimPromptUser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ internal sealed class CimPromptUser : CimSyncAction
/// <summary>
/// Constructor.
/// </summary>
public CimPromptUser(string message,
internal CimPromptUser(string message,
CimPromptType prompt)
{
this.message = message;
Expand All @@ -40,7 +40,7 @@ public CimPromptUser(string message,
/// cmdlet wrapper object, to which write result.
/// <see cref="CmdletOperationBase"/> for details.
/// </param>
public override void Execute(CmdletOperationBase cmdlet)
internal override void Execute(CmdletOperationBase cmdlet)
{
ValidationHelper.ValidateNoNullArgument(cmdlet, "cmdlet");

Expand Down Expand Up @@ -121,7 +121,7 @@ public override void Execute(CmdletOperationBase cmdlet)
/// <summary>
/// Prompt message.
/// </summary>
public string Message
internal string Message
{
get
{
Expand Down
18 changes: 9 additions & 9 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimRegisterCimIndication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ internal abstract class CimSubscriptionEventArgs : EventArgs
/// Returns an Object value for an operation context
/// </para>
/// </summary>
public object Context
internal object Context
{
get
{
Expand All @@ -47,7 +47,7 @@ internal class CimSubscriptionResultEventArgs : CimSubscriptionEventArgs
/// subscription result
/// </para>
/// </summary>
public CimSubscriptionResult Result
internal CimSubscriptionResult Result
{
get
{
Expand All @@ -61,7 +61,7 @@ public CimSubscriptionResult Result
/// <para>Constructor</para>
/// </summary>
/// <param name="theResult"></param>
public CimSubscriptionResultEventArgs(
internal CimSubscriptionResultEventArgs(
CimSubscriptionResult theResult)
{
this.context = null;
Expand All @@ -81,7 +81,7 @@ internal class CimSubscriptionExceptionEventArgs : CimSubscriptionEventArgs
/// subscription result
/// </para>
/// </summary>
public Exception Exception
internal Exception Exception
{
get
{
Expand All @@ -95,7 +95,7 @@ public Exception Exception
/// <para>Constructor</para>
/// </summary>
/// <param name="theResult"></param>
public CimSubscriptionExceptionEventArgs(
internal CimSubscriptionExceptionEventArgs(
Exception theException)
{
this.context = null;
Expand All @@ -115,14 +115,14 @@ internal sealed class CimRegisterCimIndication : CimAsyncOperation
/// New subscription result event
/// </para>
/// </summary>
public event EventHandler<CimSubscriptionEventArgs> OnNewSubscriptionResult;
internal event EventHandler<CimSubscriptionEventArgs> OnNewSubscriptionResult;

/// <summary>
/// <para>
/// Constructor
/// </para>
/// </summary>
public CimRegisterCimIndication()
internal CimRegisterCimIndication()
: base()
{
this.ackedEvent = new ManualResetEventSlim(false);
Expand All @@ -136,7 +136,7 @@ public CimRegisterCimIndication()
/// <param name="queryDialect"></param>
/// <param name="queryExpression"></param>
/// <param name="operationTimeout"></param>
public void RegisterCimIndication(
internal void RegisterCimIndication(
string computerName,
string nameSpace,
string queryDialect,
Expand All @@ -159,7 +159,7 @@ public void RegisterCimIndication(
/// <param name="queryExpression"></param>
/// <param name="operationTimeout"></param>
/// <exception cref="ArgumentNullException">Throw if cimSession is null.</exception>
public void RegisterCimIndication(
internal void RegisterCimIndication(
CimSession cimSession,
string nameSpace,
string queryDialect,
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimRemoveCimInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ internal sealed class CimRemoveCimInstance : CimGetInstance
/// Constructor
/// </para>
/// </summary>
public CimRemoveCimInstance()
internal CimRemoveCimInstance()
: base()
{
}
Expand All @@ -56,7 +56,7 @@ public CimRemoveCimInstance()
/// </para>
/// </summary>
/// <param name="cmdlet"><see cref="GetCimInstanceCommand"/> object.</param>
public void RemoveCimInstance(RemoveCimInstanceCommand cmdlet)
internal void RemoveCimInstance(RemoveCimInstanceCommand cmdlet)
{
DebugHelper.WriteLogEx();

Expand Down
Loading