Skip to content

WIP: Replace compareinfo compare #13411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xtqqczze wants to merge 4 commits into from
Closed

WIP: Replace compareinfo compare #13411

xtqqczze wants to merge 4 commits into from

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 12, 2020 •
edited
Loading

PR Summary

call the static method instead of instance method

PR Context

PR Checklist

@ghost ghost assigned iSazonov Aug 12, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 15, 2020
@ghost ghost added the Stale label Aug 30, 2020
@ghost
Copy link

ghost commented Aug 30, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Sep 10, 2020
@iSazonov iSazonov reopened this Oct 16, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 16, 2020

@xtqqczze Is it still Draft?

@ghost ghost removed the Stale label Oct 16, 2020
@xtqqczze xtqqczze marked this pull request as ready for review October 22, 2020 22:57
@xtqqczze xtqqczze requested a review from anmenaga as a code owner October 22, 2020 22:57
@xtqqczze
Use string.Compare
298dbb8 
Use `string.Compare` static method instead of `CompareInfo.Compare` instance method
@xtqqczze
Wrap arguments for clarity
1c13c23
@xtqqczze
Use StringComparison.Ordinal for culture-agnostic string matching
fd6af4a
@xtqqczze xtqqczze force-pushed the replace-compareinfo-compare branch from 735cb71 to fd6af4a Compare October 22, 2020 22:59
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 22, 2020

rebased

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 22, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 30, 2020
@ghost
Copy link

ghost commented Oct 30, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze xtqqczze marked this pull request as draft October 30, 2020 15:07
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 2, 2020
@ghost ghost added the Stale label Nov 17, 2020
@ghost
Copy link

ghost commented Nov 17, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 21, 2020

Still draft? What benefits? Please add in the PR description.

@ghost ghost removed Stale Review - Needed The PR is being reviewed labels Nov 21, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 24, 2020

Depends on #14148.

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 24, 2020
@ghost ghost added the Stale label Dec 12, 2020
@ghost
Copy link

ghost commented Dec 12, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@SteveL-MSFT SteveL-MSFT added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 15, 2020
@ghost ghost closed this Dec 26, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @SteveL-MSFT