Skip to content

Autofix RCS1036: Remove redundant empty line - #13404

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
xtqqczze:RCS1036
Aug 25, 2020
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
xtqqczze:RCS1036

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 11, 2020 •

Copy link
Copy Markdown
Contributor

PR Summary

Fixes SA1506: A documentation header line must not be followed by a blank line.

PR Context

Changes split from #13334

PR Checklist

Fixes SA1506: A documentation header line must not be followed by a blank line.

Follow-up to PowerShell#13334, PowerShell#13334
@xtqqczze

ghost commented Aug 11, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Can you reapprove, this PR is identical to 92c64d7 in #13334

@iSazonov Ilya (iSazonov) added Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers size/XL labels Aug 12, 2020
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 12, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 22, 2020

ghost commented Aug 22, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

ghost commented Aug 22, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Can you merge?

@iSazonov

ghost commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze We need a confirmation from MSFT maintainers for large PRs.

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 23, 2020
@xtqqczze

ghost commented Aug 23, 2020

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) Could you approve and merge these changes?

@daxian-dbw Dongbo Wang (daxian-dbw) removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Aug 24, 2020
@daxian-dbw

ghost commented Aug 24, 2020

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) Please remind me in 12 hours

@PoshChan

ghost commented Aug 25, 2020

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), this is the reminder you requested 12 hours ago

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 16f0b74 into PowerShell:master Aug 25, 2020
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.7 milestone Aug 26, 2020
@xtqqczze
xtqqczze deleted the RCS1036 branch August 27, 2020 02:25

ghost commented Sep 8, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze

ghost commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

This PR made changes to ComInterop, so a corresponding PR has been opened at dotnet/runtime#44631 to avoid the codebase's diverging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants