Skip to content

Enable IDE0074: Use coalesce compound assignment #13396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 6 commits into from
Nov 25, 2020
Merged

Enable IDE0074: Use coalesce compound assignment #13396

iSazonov merged 6 commits into from
Nov 25, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 11, 2020 •
edited
Loading

PR Summary

Use C# 8.0 null-coalescing assignment.

PR Context

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074

PR Checklist

This change is Reviewable

@ghost ghost assigned iSazonov Aug 11, 2020
@iSazonov iSazonov added Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log labels Aug 11, 2020
vexx32
vexx32 reviewed Aug 11, 2020
View reviewed changes
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Aug 28, 2020

Codacy issue is not new.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Aug 28, 2020

@TravisEz13 can you please review?

@daxian-dbw
Copy link
Member

daxian-dbw commented Sep 1, 2020

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it for 7.2-preview, namely delay merging this PR until after 7.1-RC1 release branch gets created. The decision is based on the following reason(s):

The changes make sense, but they are actual code changes and the chance of regression is relatively high. So it requires line-by-line review to make sure changes are correct.

@ghost ghost removed the Review - Needed The PR is being reviewed label Sep 1, 2020
@daxian-dbw daxian-dbw removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 1, 2020
@iSazonov iSazonov marked this pull request as draft September 2, 2020 03:16
@iSazonov
Copy link
Collaborator

iSazonov commented Sep 2, 2020

Set to Draft till 7.2 Preview1.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 5, 2020
@ghost ghost added the Stale label Sep 20, 2020
@ghost
Copy link

ghost commented Sep 20, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Sep 30, 2020
@iSazonov iSazonov reopened this Oct 16, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 16, 2020

@xtqqczze Is it still Draft?

@ghost ghost removed the Stale label Oct 16, 2020
@xtqqczze xtqqczze marked this pull request as ready for review October 22, 2020 14:12
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 22, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 22, 2020

rebased to restart tests

@xtqqczze xtqqczze changed the title Fix IDE0074: Use compound assignment Fix IDE0074: Use coalesce compound assignment Oct 22, 2020
@xtqqczze xtqqczze mentioned this pull request Oct 22, 2020
Merged
8 tasks
TravisEz13
TravisEz13 reviewed Oct 25, 2020
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 out of 55 files.

@TravisEz13
Copy link
Member

TravisEz13 commented Oct 25, 2020

@PoshChan Please remind me in 7 days

@xtqqczze xtqqczze changed the title Fix IDE0074: Use coalesce compound assignment Enable IDE0074: Use coalesce compound assignment Oct 26, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 5, 2020

@xtqqczze Please resolve merge conflicts.

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 5, 2020

Resolved merge conflicts.

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 5, 2020

@TravisEz13 Do you want to continue the code review?

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 13, 2020
@ghost
Copy link

ghost commented Nov 13, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 25, 2020

@iSazonov Can we merge?

@iSazonov iSazonov merged commit 0d1ea73 into PowerShell:master Nov 25, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 25, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 25, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Nov 26, 2020

@iSazonov CodeFactor is showing 3542 fixed issues for this PR taking us from grade F to grade D. Unfortunately the fixed issues list is not accurate :(

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 26, 2020 •
edited by unfurl-links bot
Loading

@xtqqczze Perhaps it is because the PR was old.

You could ask them https://www.codefactor.io/contact or twitter.

Quality software, faster.

@xtqqczze xtqqczze mentioned this pull request Dec 2, 2020
Closed
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 2, 2020 •
edited
Loading

@xtqqczze Perhaps it is because the PR was old.

You could ask them https://www.codefactor.io/contact or twitter.

Issue opened: codefactor-io/codefactor#27.

@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 16, 2020

@xtqqczze we have prioritized this ticket and it is currently Work-In-Progress. Some updates have already been pushed to production so you should already see improved analysis results for C# 8.0 and 9.0. The full scope will be rolled out by the end of January 2021.

Originally posted by @kaskas in codefactor-io/codefactor#27 (comment)

@xtqqczze xtqqczze deleted the IDE0074 branch March 22, 2021 23:10
@xtqqczze xtqqczze mentioned this pull request Mar 22, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

+1 more reviewer

@vexx32 vexx32 vexx32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log size/XL

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @daxian-dbw @iSazonov @TravisEz13 @vexx32