Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check #13333

xtqqczze · 2020-08-01T17:15:46Z

PR Summary

Autofix RCS1221

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- [NA] Experimental feature(s) needed
  - [NA] Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- [NA] Documentation needed
  - [NA] Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- [NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

This change is

xtqqczze · 2020-08-02T16:55:05Z

Reverted IDE0019 commits due to high number of issues.

xtqqczze · 2020-08-03T19:25:21Z

PR is ready for review

xtqqczze · 2020-08-10T15:26:34Z

@iSazonov Can you review?

iSazonov

LGTM with one comment.

src/System.Management.Automation/help/ProviderContext.cs

daxian-dbw · 2020-09-01T22:01:13Z

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it for 7.2-preivew. So we should delay merging it until after 7.1-RC1 release branch gets created.

The changes make sense, but it requires line-by-line review to make sure there is no potential incorrect change, so it's better to delay merging it till 7.2 preview to avoid possible regression.

iSazonov · 2020-09-02T03:25:49Z

Set Draft till 7.2. Preview1.

ghost · 2020-09-20T08:00:28Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

xtqqczze · 2020-10-21T13:07:22Z

@iSazonov Please restart PowerShell-CI-windows another time.

iSazonov · 2020-10-21T13:37:19Z

Restarted CI Windows.

xtqqczze · 2020-10-22T00:01:25Z

@iSazonov It seems Github is still reporting the old PowerShell-CI-windows result. I shall rerun tests by rebasing instead.

xtqqczze · 2020-10-22T13:08:25Z

@iSazonov Should I fix pre-existing Codacy issues : Add curly braces around the nested statement(s) in this 'if' block.?

iSazonov · 2020-10-22T14:35:19Z

@iSazonov Should I fix pre-existing Codacy issues : Add curly braces around the nested statement(s) in this 'if' block.?

In follow PR only.

…operator and null check https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1221.md

iSazonov · 2020-11-05T05:46:45Z

Use is not syntax (like Use is not syntax and remove unnecessary parentheses #13323, every change has been manually reviewed)

I don't see the change in the PR but we can do this later and I am ready to merge.

xtqqczze · 2020-11-05T16:20:53Z

Use is not syntax (like Use is not syntax and remove unnecessary parentheses #13323, every change has been manually reviewed)

I don't see the change in the PR but we can do this later and I am ready to merge.

I think this change was removed in a rebase to refocus the PR. Further is not changes can be made in follow-up PR. So please merge this PR.

iSazonov · 2020-11-05T17:01:35Z

@xtqqczze Do you think about forcing Roslynator rules? We could add new GitHub Check.

xtqqczze · 2020-11-05T17:08:25Z

@iSazonov I used Roslynator to make these changes as it was the easiest tool for me at the time of the PR. Now codestyle analyzers are included in .NET 5.0 we can use IDE0019 instead, see #13895.

iSazonov · 2020-11-05T17:29:12Z

Now codestyle analyzers are included in .NET 5.0

All?

xtqqczze · 2020-11-05T21:22:47Z

Now codestyle analyzers are included in .NET 5.0

All?

Many RCSXXXX rules have crossover with IDEXXXX and CAXXXX. If we also add StyleCop analyzers package like in #13963 we can likely cover most scenarios.

ghost · 2020-11-17T23:01:21Z

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

xtqqczze requested review from adityapatwardhan, anmenaga and daxian-dbw as code owners August 1, 2020 17:15

ghost assigned rjmholt Aug 1, 2020

xtqqczze requested review from SteveL-MSFT and TravisEz13 as code owners August 1, 2020 22:00

xtqqczze force-pushed the RCS1221 branch 3 times, most recently from 65557c3 to 03e25bf Compare August 2, 2020 16:49

xtqqczze marked this pull request as draft August 2, 2020 17:00

xtqqczze marked this pull request as ready for review August 3, 2020 19:05

xtqqczze changed the title ~~Use pattern matching instead of combination of 'as' operator and null check~~ Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check Aug 3, 2020

rjmholt added Review - Needed The PR is being reviewed Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers labels Aug 3, 2020

iSazonov approved these changes Aug 10, 2020

View reviewed changes

src/System.Management.Automation/help/ProviderContext.cs Outdated Show resolved Hide resolved

ghost removed the Review - Needed The PR is being reviewed label Sep 1, 2020

daxian-dbw removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 1, 2020

iSazonov marked this pull request as draft September 2, 2020 03:25

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 5, 2020

ghost added the Stale label Sep 20, 2020

ghost closed this Sep 30, 2020

rjmholt removed Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Sep 30, 2020

rjmholt reopened this Sep 30, 2020

ghost removed the Review - Needed The PR is being reviewed label Oct 21, 2020

xtqqczze force-pushed the RCS1221 branch from e6fb739 to 4ba68c0 Compare October 22, 2020 00:01

iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 22, 2020

This was referenced Oct 26, 2020

Use is not null syntax #13286

Closed

WIP: Enable IDE0019: InlineAsTypeCheck #13895

Closed

xtqqczze force-pushed the RCS1221 branch from 8228cf5 to f0b9981 Compare October 26, 2020 20:16

xtqqczze marked this pull request as draft October 26, 2020 20:17

xtqqczze added 2 commits October 26, 2020 20:18

Autofix RCS1221: Use pattern matching instead of combination of 'as' …

dbaa79f

…operator and null check https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1221.md

Restore stripped comments

6fc7e01

xtqqczze force-pushed the RCS1221 branch from f0b9981 to 6fc7e01 Compare October 26, 2020 20:19

xtqqczze marked this pull request as ready for review October 29, 2020 22:10

iSazonov approved these changes Nov 5, 2020

View reviewed changes

iSazonov merged commit 76cef3b into PowerShell:master Nov 5, 2020

iSazonov assigned iSazonov and unassigned rjmholt Nov 5, 2020

iSazonov added this to the 7.2.0-preview.1 milestone Nov 5, 2020

xtqqczze deleted the RCS1221 branch November 5, 2020 17:00

xtqqczze mentioned this pull request Oct 27, 2022

Enable IDE0019: InlineAsTypeCheck #18399

Closed

Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check #13333

Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check #13333

Uh oh!

Conversation

xtqqczze commented Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

xtqqczze commented Aug 2, 2020

Uh oh!

xtqqczze commented Aug 3, 2020

Uh oh!

xtqqczze commented Aug 10, 2020

Uh oh!

iSazonov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daxian-dbw commented Sep 1, 2020

Uh oh!

iSazonov commented Sep 2, 2020

Uh oh!

ghost commented Sep 20, 2020

Uh oh!

xtqqczze commented Oct 21, 2020

Uh oh!

iSazonov commented Oct 21, 2020

Uh oh!

xtqqczze commented Oct 22, 2020

Uh oh!

xtqqczze commented Oct 22, 2020

Uh oh!

iSazonov commented Oct 22, 2020

Uh oh!

iSazonov commented Nov 5, 2020

Uh oh!

xtqqczze commented Nov 5, 2020

Uh oh!

iSazonov commented Nov 5, 2020

Uh oh!

xtqqczze commented Nov 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Nov 5, 2020

Uh oh!

xtqqczze commented Nov 5, 2020

Uh oh!

ghost commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xtqqczze commented Aug 1, 2020 •

edited

Loading

xtqqczze commented Nov 5, 2020 •

edited

Loading