Skip to content

Conversation

@rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Jul 31, 2020

Reverts #13321

The GitHub action is currently failing in new PRs, so we need more configuration to make it work properly it seems.

@vexx32
Copy link
Collaborator

vexx32 commented Jul 31, 2020

@SteveL-MSFT is this functionality something PoshChan could handle?

@rjmholt rjmholt added the CL-NotInBuild Indicates that a PR is reverted and not part of the build. label Jul 31, 2020
@daxian-dbw
Copy link
Member

@TravisEz13 Shall we merge this one sooner?

@TravisEz13
Copy link
Member

Can we give an example of where it's failing?

@TravisEz13
Copy link
Member

TravisEz13 commented Jul 31, 2020

https://github.com/PowerShell/PowerShell/runs/932788471?check_suite_focus=true

looks like its rate limited (even with auth). We can filter the events to reduce the load.

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@TravisEz13
Copy link
Member

This should help with the problem

@vexx32
Copy link
Collaborator

vexx32 commented Jul 31, 2020

That output doesn't read to me as being rate-limited:

{ RequestError [HttpError]: Resource not accessible by integration
    at response.text.then.message (/usr/local/share/.config/yarn/global/node_modules/@octokit/request/dist-node/index.js:66:23)
    at processTicksAndRejections (internal/process/task_queues.js:86:5)
...
     'x-ratelimit-limit': '15000',
     'x-ratelimit-remaining': '14998',
     'x-ratelimit-reset': '1596216976',

Plenty of attempts remaining, and that error doesn't look like "try again later" it reads more "access denied" to me.

@TravisEz13 TravisEz13 merged commit 5abcd58 into master Jul 31, 2020
@TravisEz13 TravisEz13 deleted the revert-13321-TravisEz13-patch-2 branch July 31, 2020 18:06
TravisEz13 added a commit that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants