Skip to content

Reinstate Test-Connection tests #13324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 5 commits into from
Nov 14, 2020
Merged

Reinstate Test-Connection tests #13324

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68e3780
Move tests back to using hostname
rjmholt Jul 31, 2020
a050341
$realAddress -> $hostAddress
rjmholt Jul 31, 2020
a7c6c40
Go back to $testAddress
rjmholt Jul 31, 2020
4c843fa
Move MTU tests to targetAddress
rjmholt Jul 31, 2020
cc758ef
Remove commented out code
rjmholt Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Describe "Test-Connection" -tags "CI" {
$targetAddress = "127.0.0.1"
$targetAddressIPv6 = "::1"
$UnreachableAddress = "10.11.12.13"

# under some environments, we can't round trip this and retrieve the real name from the address
# in this case we will simply use the hostname
$jobContinues = Start-Job { Test-Connection $using:targetAddress -Repeat }
Expand Down Expand Up @@ -105,7 +106,7 @@ Describe "Test-Connection" -tags "CI" {
$error[0].Exception.InnerException.ErrorCode | Should -Be $code
}

It "Force IPv4 with implicit PingOptions" -Pending {
It "Force IPv4 with implicit PingOptions" {
Copy link
Contributor

@PaulHigin PaulHigin Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment as to why it is marked 'pending'.

Copy link
Collaborator

@vexx32 vexx32 Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pending was removed from this test?

$result = Test-Connection $testAddress -Count 1 -IPv4

$result[0].Address | Should -BeExactly $testAddress
Expand All @@ -116,6 +117,7 @@ Describe "Test-Connection" -tags "CI" {
}

# In VSTS, address is 0.0.0.0
# This test is marked as PENDING as .NET Core does not return correct PingOptions from ping request
It "Force IPv4 with explicit PingOptions" -Pending {
$result1 = Test-Connection $testAddress -Count 1 -IPv4 -MaxHops 10 -DontFragment

Expand Down Expand Up @@ -259,7 +261,7 @@ Describe "Test-Connection" -tags "CI" {
Context "MTUSizeDetect" {
# We skip the MtuSize detection tests when in containers, as the environments throw raw exceptions
# instead of returning a PacketTooBig response cleanly.
It "MTUSizeDetect works" -Pending:($true -or $env:__INCONTAINER -eq 1) {
It "MTUSizeDetect works" -Pending:($env:__INCONTAINER -eq 1) {
$result = Test-Connection $testAddress -MtuSize

$result | Should -BeOfType Microsoft.PowerShell.Commands.TestConnectionCommand+PingMtuStatus
Expand All @@ -282,7 +284,7 @@ Describe "Test-Connection" -tags "CI" {
$result = Test-Connection $testAddress -TraceRoute -IPv4

$result[0] | Should -BeOfType Microsoft.PowerShell.Commands.TestConnectionCommand+TraceStatus
$result[0].Source | Should -BeExactly $hostName
$result[0].Source | Should -BeExactly $testAddress
$result[0].TargetAddress | Should -BeExactly $testAddress
$result[0].Target | Should -BeExactly $testAddress
$result[0].Hop | Should -Be 1
Expand Down