Skip to content

Revert "Use is null syntax" #13322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 1 commit into from
Jul 30, 2020
Merged

Revert "Use is null syntax" #13322

daxian-dbw merged 1 commit into from
Jul 30, 2020

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 30, 2020

Reverts #13277

Quote from #13277 (comment)

As for this PR, the rest of maintainers discussed about it offline, and we all agree that we shouldn't force is null over == null. We think they clearly are appropriate in different scenarios. Changes in this PR will not only result in conflicts in other existing PRs, but also raise disputes in future contributions because people will continue to use == null and argue for it. So we decided to revert this PR.

@ghost ghost assigned anmenaga Jul 30, 2020
@daxian-dbw
Copy link
Member Author

daxian-dbw commented Jul 30, 2020

@PoshChan Please remind me in 1 hour

@daxian-dbw daxian-dbw merged commit 4b9b078 into master Jul 30, 2020
@daxian-dbw daxian-dbw deleted the revert-13277-isnull branch July 30, 2020 23:06
@PoshChan
Copy link
Collaborator

PoshChan commented Jul 30, 2020

@daxian-dbw, this is the reminder you requested 1 hour ago

@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 30, 2020
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.7 milestone Jul 30, 2020
@daxian-dbw daxian-dbw mentioned this pull request Aug 3, 2020
Merged
14 tasks
@TravisEz13 TravisEz13 modified the milestones: 7.1.0-preview.7, 7.1.0-preview.6 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.6

Development

Successfully merging this pull request may close these issues.

6 participants

@daxian-dbw @PoshChan @rjmholt @TravisEz13 @anmenaga