Skip to content

Use 'is' operator instead of 'as' operator #13287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Aug 10, 2020
Merged

Use 'is' operator instead of 'as' operator #13287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ab5179
Autofix RCS1172: Use 'is' operator instead of 'as' operator
xtqqczze Jul 27, 2020
abaf6e1
Apply suggestions from code review
adityapatwardhan Jul 30, 2020
2c699e6
Apply suggestions from code review
xtqqczze Jul 31, 2020
7ed0391
Remove unecessary parenthesis
xtqqczze Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rosoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommandCommandInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public ShowCommandCommandInfo(PSObject other)
var parameterSets = (other.Members["ParameterSets"].Value as PSObject).BaseObject as System.Collections.ArrayList;
this.ParameterSets = GetObjectEnumerable(parameterSets).Cast<PSObject>().Select(x => new ShowCommandParameterSetInfo(x)).ToList().AsReadOnly();

if (other.Members["Module"] != null && other.Members["Module"].Value as PSObject != null)
if (other.Members["Module"]?.Value is PSObject)
{
this.Module = new ShowCommandModuleInfo(other.Members["Module"].Value as PSObject);
}
Expand Down
2 changes: 1 addition & 1 deletion ...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,7 +1737,7 @@ internal long SetRequestContent(HttpRequestMessage request, XmlNode xmlNode)

byte[] bytes = null;
XmlDocument doc = xmlNode as XmlDocument;
if (doc != null && (doc.FirstChild as XmlDeclaration) != null)
if (doc?.FirstChild is XmlDeclaration)
{
XmlDeclaration decl = doc.FirstChild as XmlDeclaration;
Encoding encoding = Encoding.GetEncoding(decl.Encoding);
Expand Down
6 changes: 3 additions & 3 deletions src/System.Management.Automation/engine/remoting/commands/NewPSSessionConfigurationFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,7 @@ protected override void ProcessRecord()
ThrowTerminatingError(e.ErrorRecord);
}

if ((hashtable[ConfigFileConstants.FunctionValueToken] as ScriptBlock) == null)
if (hashtable[ConfigFileConstants.FunctionValueToken] is not ScriptBlock)
{
PSArgumentException e = new PSArgumentException(StringUtil.Format(RemotingErrorIdStrings.DISCKeyMustBeScriptBlock,
ConfigFileConstants.FunctionValueToken, ConfigFileConstants.FunctionDefinitions, _path));
Expand Down Expand Up @@ -1714,7 +1714,7 @@ protected override void ProcessRecord()
ThrowTerminatingError(e.ErrorRecord);
}

if ((hashtable[ConfigFileConstants.FunctionValueToken] as ScriptBlock) == null)
if (hashtable[ConfigFileConstants.FunctionValueToken] is not ScriptBlock)
{
PSArgumentException e = new PSArgumentException(StringUtil.Format(RemotingErrorIdStrings.DISCKeyMustBeScriptBlock,
ConfigFileConstants.FunctionValueToken, ConfigFileConstants.FunctionDefinitions, _path));
Expand Down Expand Up @@ -1951,7 +1951,7 @@ internal static string CombineHashtable(IDictionary table, StreamWriter writer,
sb.AppendFormat("{0," + (4 * (indent + 1)) + "}", string.Empty);
sb.Append(QuoteName(key));
sb.Append(" = ");
if ((table[key] as ScriptBlock) != null)
if (table[key] is ScriptBlock)
{
sb.Append(WrapScriptBlock(table[key].ToString()));
continue;
Expand Down
4 changes: 2 additions & 2 deletions src/System.Management.Automation/engine/remoting/fanin/InitialSessionStateProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,7 +1209,7 @@ private static bool FunctionDefinitionsTypeValidationCallback(string key, object
return false;
}

if ((hashtable[FunctionValueToken] as ScriptBlock) == null)
if (hashtable[FunctionValueToken] is not ScriptBlock)
{
cmdlet.WriteVerbose(StringUtil.Format(RemotingErrorIdStrings.DISCKeyMustBeScriptBlock, FunctionValueToken, key, path));
return false;
Expand Down Expand Up @@ -2221,7 +2221,7 @@ public override InitialSessionState GetInitialSessionState(PSSenderInfo senderIn
foreach (Hashtable variable in variables)
{
if (variable.ContainsKey(ConfigFileConstants.VariableValueToken) &&
((variable[ConfigFileConstants.VariableValueToken] as ScriptBlock) != null))
variable[ConfigFileConstants.VariableValueToken] is ScriptBlock)
{
iss.DynamicVariablesToDefine.Add(variable);
continue;
Expand Down