Use 'is' operator instead of 'as' operator #13287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Author
|
@iSazonov I am planning work with these analyzers too:
Would you prefer seperate PRs or to add commits here?
|
iSazonov
reviewed
Jul 27, 2020
src/System.Management.Automation/engine/remoting/commands/NewPSSessionConfigurationFile.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/commands/NewPSSessionConfigurationFile.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/fanin/InitialSessionStateProvider.cs
Outdated
Show resolved
Hide resolved
Collaborator
I am unlike this. It is not add readability. Please skip. Good! I am unlike this. It is not add readability. Please skip. Good! Good but we should replace "!(... is ...)" with "is not" on second pass.
Please pull new PR for every change - this simplify a code review.
|
vexx32
approved these changes
Jul 30, 2020
Collaborator
vexx32
left a comment
vexx32
left a comment
There was a problem hiding this comment.
I think we can simplify a couple of these a little further, but everything else looks good. Nice work!
...Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommandCommandInfo.cs
Outdated
Show resolved
Hide resolved
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
Outdated
Show resolved
Hide resolved
xtqqczze
changed the title
Merged
8 tasks
iSazonov
approved these changes
Aug 3, 2020
Collaborator
|
@xtqqczze Please rebase to pass CIs. |
iSazonov
added
the
CL-CodeCleanup
Co-authored-by: Ilya <darpa@yandex.ru>
Co-authored-by: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
Contributor
Author
|
rebased to restart CI |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1172.md
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.