Skip to content

Fix comparison of value type object to null #13285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 3 commits into from
Aug 10, 2020
Merged

Fix comparison of value type object to null #13285

anmenaga merged 3 commits into from
Aug 10, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 27, 2020 •
edited
Loading

PR Summary

  • Fix comparison of value type object to null

PR Context

#13286

PR Checklist

@ghost ghost assigned anmenaga Jul 27, 2020
@xtqqczze xtqqczze mentioned this pull request Jul 27, 2020
Merged
14 tasks
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 30, 2020
@xtqqczze xtqqczze mentioned this pull request Jul 30, 2020
Closed
14 tasks
@xtqqczze xtqqczze marked this pull request as ready for review July 30, 2020 21:16
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 30, 2020
@xtqqczze xtqqczze changed the title Autofix RCS1166: Value type object is never equal to null Fix RCS1166: Value type object is never equal to null Jul 30, 2020
daxian-dbw
daxian-dbw approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@xtqqczze xtqqczze changed the title Fix RCS1166: Value type object is never equal to null Fix comparison of value type object to null Jul 31, 2020
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 31, 2020

rebased to restart CI

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 8, 2020
@ghost
Copy link

ghost commented Aug 8, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze xtqqczze mentioned this pull request Aug 8, 2020
Merged
8 tasks
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Aug 8, 2020

rebased to pass CI

@anmenaga anmenaga merged commit d8f8f0a into PowerShell:master Aug 10, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 10, 2020
@anmenaga anmenaga added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 10, 2020
@xtqqczze xtqqczze deleted the RCS1166 branch August 10, 2020 23:08
@ghost
Copy link

ghost commented Aug 17, 2020

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@anmenaga anmenaga

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @daxian-dbw @anmenaga