Remove rcedit dependency, move daily ico dependency to props file #13123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
rjmholt
reviewed
Jul 7, 2020
TravisEz13
approved these changes
Jul 7, 2020
14 tasks
rjmholt
approved these changes
Jul 7, 2020
rjmholt
added
Area-Maintainers-Build
TravisEz13
approved these changes
Jul 7, 2020
Collaborator
|
Sorry for being late, but I wonder why do we need a special path if we can add new line here: PowerShell/PowerShell.Common.props Lines 65 to 66 in 90c7ed6 We could simple check an environment variable in the condition. |
Member
Author
|
wow nice find @iSazonov! That did the trick! |
TylerLeonhardt
commented
Jul 8, 2020
Collaborator
|
@TravisEz13 @rjmholt Please review the PR again. |
iSazonov
approved these changes
Jul 13, 2020
rjmholt
suggested changes
Jul 13, 2020
Collaborator
rjmholt
left a comment
rjmholt
left a comment
There was a problem hiding this comment.
I think we should remove the debug configuration to make commit picking easier
ghost
added
the
Waiting on Author
ghost
removed
the
Waiting on Author
Member
Author
|
done |
rjmholt
approved these changes
Jul 13, 2020
Collaborator
|
It seems CI-install fail is related #13163. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
rjmholt
changed the title
rjmholt
changed the title
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Move rcedit logic to the packaging script so that rcedit is run at packing time instead of during the installation.
PR Context
Currently rcedit (which sets the icon to the PowerShell avatar ico file) both:
This PR moves that logic from install-powershell.ps1 to packaging.psm1
This also includes a launch config that was used to debug the packaging script.
I did verify that the icon changed at package time.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.