WIP: Cmdline changes set for 7.2 (draft) #13099
Conversation
* do what PowerShell#13089 says. consolidate and fix cmdline escaping. * an empty string check. native commands can accept empty arguments! * attempt wildcard by spaces. now we do it by bareword.
|
|
|
How did I eff up passing a literal raw space character... Just FYI, the build on my mac is failing with some complaints about |
Fecked up the forceQuote logic. Guess that's why.
Empty arguments are seen as significant now, so we have to be explicitly passing an empty list in the position.
What isn't valid is a missing argv entry after -c.
|
Turns out the biggest trove of code that relies on the ad hoc behavior is the pester suite. This does turn out to be a nice set of examples to illustrate the point (urgh), so that's definitely going into the writeup. We really need to add a paragraph about native stuff in about_Parameters. Integrating this back with the legacy code to make it an experimental switch would take some time too. The code is gonna look incoherent again. |
|
|
These changes do not yet take into account the experimental feature switch needed. After such a switch has happened, some of the tests will be changed to explicitly specify legacy or current behavior.
ghost
added
the
Waiting on Author
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
ghost
closed this
|
Oh shit... |
ghost
removed
Waiting on Author
2 participants
THIS IS ONLY A DRAFT. I AM HERE FOR THE CI RESULTS ON WINDOWS AND STUFF.
PR Summary
fix #1995
PR Context
See #1995, #13089, #13098.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerStart-Processlooks fine.