Skip to content

Check for ico file in daily install script #13078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rjmholt wants to merge 2 commits into from
Closed

Check for ico file in daily install script #13078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47325e5
Check for ico file in daily install script
rjmholt Jul 1, 2020
1bf15fe
Remove extraneous line
rjmholt Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/install-powershell.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,8 @@ try {
}

# Edit icon to disambiguate daily builds.
if ($IsWinEnv -and $Daily.IsPresent) {
$icoPath = "$Destination\assets\PowerShell_avatar.ico"
if ($IsWinEnv -and $Daily.IsPresent -and (Test-Path -Path $icoPath)) {
if (-not (Test-Path "~/.rcedit/rcedit-x64.exe")) {
Write-Verbose "Install RCEdit for modifying exe resources" -Verbose
$rceditUrl = "https://github.com/electron/rcedit/releases/download/v1.0.0/rcedit-x64.exe"
Expand All @@ -431,7 +432,7 @@ try {
}

Write-Verbose "Change icon to disambiguate it from a released installation" -Verbose
& "~/.rcedit/rcedit-x64.exe" "$Destination\pwsh.exe" --set-icon "$Destination\assets\Powershell_avatar.ico"
& "~/.rcedit/rcedit-x64.exe" "$Destination\pwsh.exe" --set-icon $icoPath
}

## Change the mode of 'pwsh' to 'rwxr-xr-x' to allow execution
Expand Down