Correct stable and preview upgrade codes for MSI
#13036
Conversation
ghost
assigned
| <?define ExplorerContextMenuDialogText = "&$(var.ProductName) $(env.SimpleProductVersion)"?> | ||
| <?define UpgradeCodePreview = "31ab5147-9a97-4452-8443-d9709f0516e1"?> | ||
| <?define UpgradeCodeRelease = "39243d76-adaf-42b1-94fb-16ecf83237c8"?> | ||
| <?define UpgradeCodePreview = "39243d76-adaf-42b1-94fb-16ecf83237c8"?> |
There was a problem hiding this comment.
From - https://github.com/PowerShell/PowerShell/pull/12792/files#r445866081
preview upgrade codes
x64 - 39243d76-adaf-42b1-94fb-16ecf83237c8
x86 - 86abcfbd-1ccc-4a88-b8b2-0facfde29094
release upgrade codes
"UpgradeCodeX64", '31ab5147-9a97-4452-8443-d9709f0516e1', "Process")
"UpgradeCodeX86", '1d00683b-0f84-4db8-a64f-2f98ad42fe06', "Process")
There was a problem hiding this comment.
I'm curious where does var.IsPreview declared?
There was a problem hiding this comment.
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
Sorry about that. I tested all the upgrade scenarios in a sandbox using generated MSIs, but should've also tested against then-released MSIs.
TravisEz13
added
the
CL-BuildPackaging
|
|
||
| Context "Upgrade code" { | ||
| BeforeAll { | ||
| $previewUpgladeCode = '39243d76-adaf-42b1-94fb-16ecf83237c8' |
There was a problem hiding this comment.
If we add tests for Preview why not for Release?
If we add tests for x64 should we skip the tests on x86?
|
in a similar note, trying to install 7.0.2, it thinks there is a higher version already: |
|
@iSazonov ok to merge this? |
Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
This is after installing preview.4? |
|
@PoshChan Please remind me in 30 minutes |
|
@TravisEz13, this is the reminder you requested 30 minutes ago |
TravisEz13
changed the title
MSI
|
🎉 Handy links: |
|
just tried to reinstall 7.0.2 and still getting same message as before: #13036 (comment) |
|
If you installed the newer preview, you'll need to first uninstall it. |
|
@heaths thanks. that worked |
Fixes #13035
PR Summary
Correct stable and preview upgrade codes for msi
PR Context
stable and preview were reversed in:
#12792
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.