Ensure assemblies listed FileList are not loaded
#12968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
iSazonov
reviewed
Jun 16, 2020
Collaborator
There was a problem hiding this comment.
Why do we need skipLoading if we have isImportingModule?
Member
Author
There was a problem hiding this comment.
Even though we are importing the module, we should not be loading the files in FileList here. FileList is meant to be just a list of all the files in the module. It should not have effect on the loading.
Collaborator
There was a problem hiding this comment.
The new parameter description and name could be more informative.
getFileListOnly?
iSazonov
reviewed
Jun 16, 2020
test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1
Outdated
Show resolved
Hide resolved
TravisEz13
added
the
Waiting on Author
ghost
removed
the
Waiting on Author
adityapatwardhan
force-pushed
the
FileListLoad
branch
from
76cd6d5 to
0cd12fe
Compare
iSazonov
approved these changes
Jun 30, 2020
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
TravisEz13
added
the
CL-Engine
|
🎉 Handy links: |
Member
Author
|
@adityapatwardhan make sure this repros in 7.0.x |
Member
|
@SteveL-MSFT Do we want to back port this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12821
PR Summary
Assemblies listed in
FileListof thepsd1should not be loaded when the module is loaded. This change fixes the regression introduced in6.2.0-preview.2PR Context
Regression was introduced as a side effect of #8073
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.