Skip to content

Remove positional assignment of QUALIFIER for SPLIT-PATH #12960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 5 commits into from
Jun 16, 2020
Merged

Remove positional assignment of QUALIFIER for SPLIT-PATH #12960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ab1907
QUALIFIER for SPLIT-PATH should not be positional
yecril71pl Jun 14, 2020
1d74f7d
Verify SPLIT-PATH errors given parameter #2
yecril71pl Jun 14, 2020
075f6c9
Parameters are not mandatory by default.
yecril71pl Jun 15, 2020
05558f9
Fix indentation of the new code
daxian-dbw Jun 15, 2020
9e4182f
Add ErrorId to test against positional parameter
yecril71pl Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/ParsePathCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public string[] LiteralPath
/// The qualifier is the drive or provider that is qualifying
/// the MSH path.
/// </value>
[Parameter(Position = 1, ValueFromPipelineByPropertyName = true, ParameterSetName = qualifierSet, Mandatory = false)]
[Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = qualifierSet)]
public SwitchParameter Qualifier { get; set; }

/// <summary>
Expand Down Expand Up @@ -476,4 +476,3 @@ private string RemoveQualifier(string path)
}
}
}

4 changes: 4 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Split-Path.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ Describe "Split-Path" -Tags "CI" {
{ Split-Path -Qualifier -ErrorAction Stop abcdef } | Should -Throw
}

It "Should error given positional parameter #2" {
{ Split-Path env: $NULL } | Should -Throw -ErrorId 'PositionalParameterNotFound,Microsoft.PowerShell.Commands.SplitPathCommand'
}

It "Should return the path when the noqualifier switch is used" {
Split-Path env:PATH -NoQualifier | Should -BeExactly "PATH"
}
Expand Down