-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Remove positional assignment of QUALIFIER for SPLIT-PATH #12960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax ``SPLIT-PATH C: $NULL`` is confusing and should not be supported.
As of PowerShell 7.0.2, positional parameter #2 was treated by ``SPLIT-PATH`` as a value for QUALIFIER.
iSazonov
reviewed
Jun 15, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/Split-Path.Tests.ps1
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/ParsePathCommand.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
Member
|
This should be a bucket-3 breaking change -- Unlikely Grey Area, and I'm fine take this change. |
daxian-dbw
approved these changes
Jun 15, 2020
adityapatwardhan
previously requested changes
Jun 15, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/Split-Path.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Jun 16, 2020
daxian-dbw
approved these changes
Jun 16, 2020
Member
|
|
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-BreakingChange
Indicates that a PR should be marked as a breaking change in the Change Log
CL-General
Indicates that a PR should be marked as a general cmdlet change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The syntax
SPLIT-PATH C: -QUALIFIERshould be required to pass QUALIFIER.PR Context
The syntax
SPLIT-PATH C: $NULLis confusing and should not be supported.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.