Skip to content

Remove dependency on DNS for Test-Connection tests on macOS #12943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 19 commits into from
Jun 16, 2020
Merged

Remove dependency on DNS for Test-Connection tests on macOS #12943

TravisEz13 merged 19 commits into from
Jun 16, 2020

Conversation

@rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Jun 11, 2020 •
edited
Loading

PR Summary

Fixes #12935.

macOS has had issues with DNS in CI, so this PR falls back to using the gateway address when DNS doesn't work.

Using the gateway address doesn't seem to work well on other platforms though, so we still try DNS lookup.

PR Checklist

@ghost ghost assigned anmenaga Jun 11, 2020
@rjmholt rjmholt requested review from SteveL-MSFT, TravisEz13, adityapatwardhan and iSazonov and removed request for adityapatwardhan June 11, 2020 18:26
@rjmholt
Copy link
Collaborator Author

rjmholt commented Jun 11, 2020

From CI, it seems that solving the setup issue kicks the can down to a test failure instead where Test-Connection falls over

@rjmholt
Copy link
Collaborator Author

rjmholt commented Jun 11, 2020

From the CI, it looks like ifconfig is able to resolve the address properly

@vexx32
Copy link
Collaborator

vexx32 commented Jun 11, 2020

@rjmholt the cmdlet uses the system.net.dns APIs internally quite a bit, so I'd imagine if those APIs themselves are failing it'll most likely fall apart in at least a couple of cases.

Definitely seems like something changed that the .NET Core folks will need to take a look at... 😕

@rjmholt rjmholt mentioned this pull request Jun 11, 2020
Closed
SteveL-MSFT
SteveL-MSFT reviewed Jun 12, 2020
View reviewed changes
test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1 Outdated

if (-not $?)
{
Get-Error | Out-String | Write-Host
Copy link
Member

@SteveL-MSFT SteveL-MSFT Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to use -Because with the first Should test to have this in the test log?

@rjmholt rjmholt marked this pull request as draft June 12, 2020 20:55
@rjmholt
Copy link
Collaborator Author

rjmholt commented Jun 12, 2020

Ok the latest change proves that this is a CI configuration issue rather than a .NET issue

@rjmholt rjmholt closed this Jun 12, 2020
@rjmholt
Copy link
Collaborator Author

rjmholt commented Jun 12, 2020

Reopening to run something in CI

@rjmholt rjmholt reopened this Jun 12, 2020
@rjmholt rjmholt mentioned this pull request Jun 12, 2020
Closed
6 tasks
SteveL-MSFT
SteveL-MSFT previously requested changes Jun 12, 2020
View reviewed changes
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 12, 2020
@rjmholt rjmholt changed the title Remove dependency on DNS in Test-Connection tests, re-enable tests on macOS Remove dependency on DNS for Test-Connection tests on macOS Jun 16, 2020
@rjmholt rjmholt requested a review from PaulHigin June 16, 2020 02:11
@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jun 16, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 16, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 16, 2020
@daxian-dbw daxian-dbw mentioned this pull request Jun 16, 2020
Merged
14 tasks
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jun 16, 2020

@SteveL-MSFT Please update your review

SteveL-MSFT
SteveL-MSFT reviewed Jun 16, 2020
View reviewed changes
test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
$gatewayAddress = GetGatewayAddress
$publicHostAddress = GetExternalHostAddress -HostName $hostName

$testAddress = if ($publicHostAddress) { $publicHostAddress } else { $gatewayAddress }
Copy link
Member

@SteveL-MSFT SteveL-MSFT Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but could have used the null conditional assignment operator here

Copy link
Collaborator Author

@rjmholt rjmholt Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to port back to 6.2 -- deliberately removed new operators in most recent commit

@TravisEz13 TravisEz13 dismissed SteveL-MSFT’s stale review June 16, 2020 19:36

said review was not blocking

@TravisEz13 TravisEz13 changed the title Remove dependency on DNS for Test-Connection tests on macOS Remove dependency on DNS for Test-Connection tests on macOS Jun 16, 2020
@TravisEz13 TravisEz13 merged commit a650709 into PowerShell:master Jun 16, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.4 milestone Jun 16, 2020
@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned anmenaga Jun 16, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 25, 2020
Closed
@ghost
Copy link

ghost commented Jul 16, 2020

🎉v7.0.3 has been released which incorporates this pull request.:tada:

Handy links:

@rjmholt rjmholt deleted the improve-test-connection-tests branch July 30, 2020 04:33
@rjmholt rjmholt mentioned this pull request Jul 31, 2020
Merged
14 tasks
@BrandonBoone BrandonBoone mentioned this pull request Aug 4, 2020
Closed
TravisEz13 added a commit that referenced this pull request Sep 9, 2020
@TravisEz13
Merged PR 12007: Remove dependency on DNS for Test-Connection tests…
408dbaf 
… on macOS (#12943)
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.0.x-Servicing-Consider

Development

Successfully merging this pull request may close these issues.

Test-Connection test setup fails on macOS due to DNS issue

8 participants

@rjmholt @vexx32 @adityapatwardhan @TravisEz13 @SteveL-MSFT @PaulHigin @iSazonov @anmenaga