Skip to content

Add missing accessibility modifiers #12820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
May 31, 2020
Merged

Add missing accessibility modifiers #12820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimAssociatedInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ protected override void EndProcessing()
/// used to delegate all Get-CimAssociatedInstance operations.
/// </para>
/// </summary>
CimGetAssociatedInstance GetOperationAgent()
private CimGetAssociatedInstance GetOperationAgent()
{
return this.AsyncOperation as CimGetAssociatedInstance;
}
Expand All @@ -290,7 +290,7 @@ CimGetAssociatedInstance GetOperationAgent()
/// </para>
/// </summary>
/// <returns></returns>
CimGetAssociatedInstance CreateOperationAgent()
private CimGetAssociatedInstance CreateOperationAgent()
{
this.AsyncOperation = new CimGetAssociatedInstance();
return GetOperationAgent();
Expand Down Expand Up @@ -319,7 +319,7 @@ CimGetAssociatedInstance CreateOperationAgent()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameComputerName, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -348,7 +348,7 @@ CimGetAssociatedInstance CreateOperationAgent()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.SessionSetName, new ParameterSetEntry(2, false) },
{ CimBaseCommand.ComputerSetName, new ParameterSetEntry(1, true) },
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimClassCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ protected override void EndProcessing()
/// used to delegate all New-CimInstance operations.
/// </para>
/// </summary>
CimGetCimClass GetOperationAgent()
private CimGetCimClass GetOperationAgent()
{
return (this.AsyncOperation as CimGetCimClass);
}
Expand All @@ -264,7 +264,7 @@ CimGetCimClass GetOperationAgent()
/// </para>
/// </summary>
/// <returns></returns>
CimGetCimClass CreateOperationAgent()
private CimGetCimClass CreateOperationAgent()
{
CimGetCimClass cimGetCimClass = new CimGetCimClass();
this.AsyncOperation = cimGetCimClass;
Expand Down Expand Up @@ -292,7 +292,7 @@ CimGetCimClass CreateOperationAgent()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameCimSession, new HashSet<ParameterDefinitionEntry> {
Expand All @@ -310,7 +310,7 @@ CimGetCimClass CreateOperationAgent()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.SessionSetName, new ParameterSetEntry(1) },
{ CimBaseCommand.ComputerSetName, new ParameterSetEntry(0, true) },
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ protected override void EndProcessing()
/// as enumerate instances, get instance, query instance.
/// </para>
/// </summary>
CimGetInstance GetOperationAgent()
private CimGetInstance GetOperationAgent()
{
return (this.AsyncOperation as CimGetInstance);
}
Expand All @@ -506,7 +506,7 @@ CimGetInstance GetOperationAgent()
/// </para>
/// </summary>
/// <returns></returns>
CimGetInstance CreateOperationAgent()
private CimGetInstance CreateOperationAgent()
{
CimGetInstance cimGetInstance = new CimGetInstance();
this.AsyncOperation = cimGetInstance;
Expand Down Expand Up @@ -553,7 +553,7 @@ private void CheckArgument()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameCimSession, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -657,7 +657,7 @@ private void CheckArgument()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.CimInstanceComputerSet, new ParameterSetEntry(1) },
{ CimBaseCommand.CimInstanceSessionSet, new ParameterSetEntry(2) },
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimSessionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ protected override void ProcessRecord()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameComputerName, new HashSet<ParameterDefinitionEntry> {
Expand All @@ -200,7 +200,7 @@ protected override void ProcessRecord()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.ComputerNameSet, new ParameterSetEntry(0, true) },
{ CimBaseCommand.SessionIdSet, new ParameterSetEntry(1) },
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/InvokeCimMethodCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ protected override void EndProcessing()
/// used to delegate all Invoke-CimMethod operations.
/// </para>
/// </summary>
CimInvokeCimMethod GetOperationAgent()
private CimInvokeCimMethod GetOperationAgent()
{
return this.AsyncOperation as CimInvokeCimMethod;
}
Expand All @@ -429,7 +429,7 @@ CimInvokeCimMethod GetOperationAgent()
/// </para>
/// </summary>
/// <returns></returns>
CimInvokeCimMethod CreateOperationAgent()
private CimInvokeCimMethod CreateOperationAgent()
{
CimInvokeCimMethod cimInvokeMethod = new CimInvokeCimMethod();
this.AsyncOperation = cimInvokeMethod;
Expand Down Expand Up @@ -473,7 +473,7 @@ private void CheckArgument()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameClassName, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -560,7 +560,7 @@ private void CheckArgument()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.ClassNameComputerSet, new ParameterSetEntry(2, true) },
{ CimBaseCommand.ResourceUriSessionSet, new ParameterSetEntry(3) },
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/NewCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ protected override void EndProcessing()
/// used to delegate all New-CimInstance operations.
/// </para>
/// </summary>
CimNewCimInstance GetOperationAgent()
private CimNewCimInstance GetOperationAgent()
{
return (this.AsyncOperation as CimNewCimInstance);
}
Expand All @@ -399,7 +399,7 @@ CimNewCimInstance GetOperationAgent()
/// </para>
/// </summary>
/// <returns></returns>
CimNewCimInstance CreateOperationAgent()
private CimNewCimInstance CreateOperationAgent()
{
CimNewCimInstance cimNewCimInstance = new CimNewCimInstance();
this.AsyncOperation = cimNewCimInstance;
Expand Down Expand Up @@ -441,7 +441,7 @@ private void CheckArgument()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameClassName, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -504,7 +504,7 @@ private void CheckArgument()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.ClassNameSessionSet, new ParameterSetEntry(2) },
{ CimBaseCommand.ClassNameComputerSet, new ParameterSetEntry(1, true) },
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/NewCimSessionOptionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ internal WSManSessionOptions CreateWSMANSessionOptions()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameNoEncryption, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -813,7 +813,7 @@ internal WSManSessionOptions CreateWSMANSessionOptions()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.ProtocolNameParameterSet, new ParameterSetEntry(1, true) },
{ CimBaseCommand.DcomParameterSet, new ParameterSetEntry(0) },
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/RegisterCimIndicationCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ private void SetParameter(object value, string parameterName)
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameClassName, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -357,7 +357,7 @@ private void SetParameter(object value, string parameterName)
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.QueryExpressionSessionSet, new ParameterSetEntry(2) },
{ CimBaseCommand.QueryExpressionComputerSet, new ParameterSetEntry(1) },
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/RemoveCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ protected override void EndProcessing()
/// used to delegate all Remove-CimInstance operations.
/// </para>
/// </summary>
CimRemoveCimInstance GetOperationAgent()
private CimRemoveCimInstance GetOperationAgent()
{
return (this.AsyncOperation as CimRemoveCimInstance);
}
Expand All @@ -299,7 +299,7 @@ CimRemoveCimInstance GetOperationAgent()
/// </para>
/// </summary>
/// <returns></returns>
CimRemoveCimInstance CreateOperationAgent()
private CimRemoveCimInstance CreateOperationAgent()
{
CimRemoveCimInstance cimRemoveInstance = new CimRemoveCimInstance();
this.AsyncOperation = cimRemoveInstance;
Expand All @@ -323,7 +323,7 @@ CimRemoveCimInstance CreateOperationAgent()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameCimSession, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -372,7 +372,7 @@ CimRemoveCimInstance CreateOperationAgent()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.CimInstanceComputerSet, new ParameterSetEntry(1, true) },
{ CimBaseCommand.CimInstanceSessionSet, new ParameterSetEntry(2) },
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/RemoveCimSessionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ protected override void ProcessRecord()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameCimSession, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -231,7 +231,7 @@ protected override void ProcessRecord()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.CimSessionSet, new ParameterSetEntry(1, true) },
{ CimBaseCommand.ComputerNameSet, new ParameterSetEntry(1) },
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/SetCimInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ protected override void EndProcessing()
/// used to delegate all Set-CimInstance operations.
/// </para>
/// </summary>
CimSetCimInstance GetOperationAgent()
private CimSetCimInstance GetOperationAgent()
{
return (this.AsyncOperation as CimSetCimInstance);
}
Expand All @@ -356,7 +356,7 @@ CimSetCimInstance GetOperationAgent()
/// </para>
/// </summary>
/// <returns></returns>
CimSetCimInstance CreateOperationAgent()
private CimSetCimInstance CreateOperationAgent()
{
CimSetCimInstance cimSetCimInstance = new CimSetCimInstance();
this.AsyncOperation = cimSetCimInstance;
Expand All @@ -381,7 +381,7 @@ CimSetCimInstance CreateOperationAgent()
/// <summary>
/// Static parameter definition entries.
/// </summary>
static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
private static Dictionary<string, HashSet<ParameterDefinitionEntry>> parameters = new Dictionary<string, HashSet<ParameterDefinitionEntry>>
{
{
nameCimSession, new HashSet<ParameterDefinitionEntry> {
Expand Down Expand Up @@ -438,7 +438,7 @@ CimSetCimInstance CreateOperationAgent()
/// <summary>
/// Static parameter set entries.
/// </summary>
static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
private static Dictionary<string, ParameterSetEntry> parameterSets = new Dictionary<string, ParameterSetEntry>
{
{ CimBaseCommand.QuerySessionSet, new ParameterSetEntry(3) },
{ CimBaseCommand.QueryComputerSet, new ParameterSetEntry(2) },
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.Commands.Diagnostics/PdhHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ private struct PDH_TIME_INFO
// We access those fields directly. The struct is here for reference only.
//
[StructLayout(LayoutKind.Explicit, CharSet = CharSet.Unicode)]
struct PDH_COUNTER_INFO
private struct PDH_COUNTER_INFO
{
[FieldOffset(0)] public UInt32 dwLength;
[FieldOffset(4)] public UInt32 dwType;
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ internal sealed class PropVariant : IDisposable
{
// This is actually a VarEnum value, but the VarEnum type requires 4 bytes instead of the expected 2.
[FieldOffset(0)]
ushort _valueType;
private ushort _valueType;

[FieldOffset(8)]
IntPtr _ptr;
private IntPtr _ptr;

/// <summary>
/// Set a string value.
Expand Down
10 changes: 5 additions & 5 deletions src/Microsoft.WSMan.Management/ConfigProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,17 @@ public sealed class WSManConfigProvider : NavigationCmdletProvider, ICmdletProvi
/// </summary>
private bool clearItemIsCalled = false;

WSManHelper helper = new WSManHelper();
private WSManHelper helper = new WSManHelper();

/// <summary>
/// Object contains the cache of the enumerate results for the cmdlet to execute.
/// </summary>
Dictionary<string, XmlDocument> enumerateMapping = new Dictionary<string, XmlDocument>();
private Dictionary<string, XmlDocument> enumerateMapping = new Dictionary<string, XmlDocument>();

/// <summary>
/// Mapping of ResourceURI with the XML returned by the Get call.
/// </summary>
Dictionary<string, string> getMapping = new Dictionary<string, string>();
private Dictionary<string, string> getMapping = new Dictionary<string, string>();

#region ICmdletProviderSupportsHelp Members

Expand Down Expand Up @@ -5431,13 +5431,13 @@ private bool IsValueOfParamList(string name, string[] paramcontainer)

#endregion Plugin private functions

enum ProviderMethods
private enum ProviderMethods
{
GetChildItems,
GetChildNames
};

enum WsManElementObjectTypes
private enum WsManElementObjectTypes
{
WSManConfigElement,
WSManConfigContainerElement,
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.WSMan.Management/CredSSP.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ private void UpdateGPORegistrySettings(string applicationname, string[] delegate
public class GetWSManCredSSPCommand : PSCmdlet, IDisposable
{
#region private
WSManHelper helper = null;
private WSManHelper helper = null;
/// <summary>
/// Method to get the values.
/// </summary>
Expand Down
Loading