Skip to content

cleanup: Use single expectation for each It block #12714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xtqqczze wants to merge 1 commit into from
Closed

cleanup: Use single expectation for each It block #12714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions test/powershell/Modules/ThreadJob/ThreadJob.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,24 +93,21 @@ Describe 'Basic ThreadJob Tests' -Tags 'CI' {

$job = Start-ThreadJob -ScriptBlock { "Goodbye" } -InitializationScript { "Hello" }
$results = $job | Receive-Job -Wait
$results[0] | Should -Be "Hello"
$results[1] | Should -Be "Goodbye"
$results | Should -BeExactly "Hello", "Goodbye"
}

It 'ThreadJob with ScriptBlock and Argument list' {

$job = Start-ThreadJob -ScriptBlock { param ($arg1, $arg2) $arg1; $arg2 } -ArgumentList @("Hello","Goodbye")
$results = $job | Receive-Job -Wait
$results[0] | Should -Be "Hello"
$results[1] | Should -Be "Goodbye"
$results | Should -BeExactly "Hello", "Goodbye"
}

It 'ThreadJob with ScriptBlock and piped input' {

$job = "Hello","Goodbye" | Start-ThreadJob -ScriptBlock { $input | ForEach-Object { $_ } }
$results = $job | Receive-Job -Wait
$results[0] | Should -Be "Hello"
$results[1] | Should -Be "Goodbye"
$results | Should -BeExactly "Hello", "Goodbye"
}

It 'ThreadJob with ScriptBlock and Using variables' {
Expand All @@ -130,12 +127,7 @@ Describe 'Basic ThreadJob Tests' -Tags 'CI' {
}

$results = $job | Receive-Job -Wait
$results[0] | Should -Be $Var1
$results[1] | Should -Be $Var2
$results[2] | Should -Be $Var3
$results[3] | Should -Be 2
$results[4] | Should -Be $Var4
$results[5] | Should -Be $global:GVar1
$results | Should -BeExactly $Var1, $Var2, $Var3, 2, $Var4, $global:GVar1
}

It 'ThreadJob with ScriptBlock and Using variables and argument list' {
Expand Down Expand Up @@ -172,16 +164,14 @@ Describe 'Basic ThreadJob Tests' -Tags 'CI' {

$job = Start-ThreadJob -FilePath $scriptFilePath2 -ArgumentList @("Hello","Goodbye")
$results = $job | Receive-Job -Wait
$results[0] | Should -Be "Hello"
$results[1] | Should -Be "Goodbye"
$results | Should -BeExactly "Hello", "Goodbye"
}

It 'ThreadJob with ScriptFile and piped input' {

$job = "Hello","Goodbye" | Start-ThreadJob -FilePath $scriptFilePath3
$results = $job | Receive-Job -Wait
$results[0] | Should -Be "Hello"
$results[1] | Should -Be "Goodbye"
$results | Should -BeExactly "Hello", "Goodbye"
}

It 'ThreadJob with ScriptFile and Using variables' {
Expand All @@ -191,9 +181,7 @@ Describe 'Basic ThreadJob Tests' -Tags 'CI' {

$job = Start-ThreadJob -FilePath $scriptFilePath4
$results = $job | Receive-Job -Wait
$results[0] | Should -Be $Var1
$results[1] | Should -Be 3
$results[2] | Should -Be $Array1
$results | Should -BeExactly $Var1, 3, $Array1
}

It 'ThreadJob with ScriptFile and Using variables with argument list' {
Expand Down Expand Up @@ -227,7 +215,7 @@ Describe 'Basic ThreadJob Tests' -Tags 'CI' {
It 'ThreadJob and Verbose stream output' {

$job = Start-ThreadJob -ScriptBlock { $VerbosePreference = 'Continue'; Write-Verbose "VerboseOut" } | Wait-Job
$job.Verbose | Should -Match "VerboseOut"
$job.Verbose | Should -BeExactly "VerboseOut"
}

It 'ThreadJob and Verbose stream output' {
Expand Down