Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented May 18, 2020

PR Summary

PR Context

Convention is to assert a single expectation for each It block. [1]

PR Checklist

@ghost ghost assigned daxian-dbw May 18, 2020
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not accept these changes and suggest to close the PR.

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels May 19, 2020
@xtqqczze xtqqczze marked this pull request as ready for review May 19, 2020 09:59
@xtqqczze xtqqczze force-pushed the pester-compare-array branch from 5f6ef00 to 8d6edcb Compare May 19, 2020 11:02
@xtqqczze xtqqczze marked this pull request as draft May 19, 2020 11:09
@xtqqczze xtqqczze changed the title cleanup: Use Pester4 array comparison syntax cleanup: Use single expectation for each It block May 19, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

The PR looks very dangerous. I believe this does not add benefits. I close.

@iSazonov iSazonov closed this May 27, 2020
@xtqqczze xtqqczze deleted the pester-compare-array branch May 27, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants