Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented May 5, 2020

PR Summary

PR Context

PSScriptAnalyzer v1.19.0 introduces Cmdlet parameter name casing.

PR Checklist

@ghost ghost assigned adityapatwardhan May 5, 2020
@xtqqczze xtqqczze marked this pull request as ready for review May 5, 2020 23:11
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare operators should be in low case.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 6, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.3 milestone May 6, 2020
xtqqczze and others added 2 commits May 6, 2020 11:45
@iSazonov
Copy link
Collaborator

iSazonov commented May 6, 2020

@xtqqczze In future please make one change per commit - this greatly speeds up a code review.

Also it would be nice to have static tests for this to exclude regressions in formatting (not in the PR).

@iSazonov iSazonov assigned iSazonov and unassigned adityapatwardhan May 7, 2020
@iSazonov iSazonov merged commit f438220 into PowerShell:master May 7, 2020
@iSazonov iSazonov changed the title Use correct casing for cmdlet name and cmdlet parameter name Use correct casing for cmdlet name and cmdlet parameter name in *.ps1 files May 7, 2020
@xtqqczze xtqqczze deleted the ps-formatting branch May 14, 2020 16:17
@ghost
Copy link

ghost commented May 19, 2020

🎉v7.1.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants