Skip to content

Update the build to sign any unsigned files as 3rd party Dlls #12581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 2 commits into from
May 5, 2020
Merged

Update the build to sign any unsigned files as 3rd party Dlls #12581

TravisEz13 merged 2 commits into from
May 5, 2020

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented May 5, 2020 •
edited
Loading

PR Summary

Update the release build to sign any unsigned files as 3rd party binaries

PR Context

Fixes #12452

Before the change the following files were not changed (these are the only affected files)

-a----         5/5/2020   1:07 AM        1152400 Markdig.Signed.dll                                                    
-a----         5/5/2020   1:07 AM         859040 Microsoft.ApplicationInsights.dll                                     
-a----         5/5/2020   1:07 AM       14264208 Microsoft.CodeAnalysis.CSharp.dll                                     
-a----         5/5/2020   1:07 AM        5957008 Microsoft.CodeAnalysis.dll                                            
-a----         5/5/2020   1:07 AM        1007504 Microsoft.CSharp.dll                                                  
-a----         5/5/2020   1:07 AM         298400 Microsoft.Management.Infrastructure.dll                               
-a----         5/5/2020   1:07 AM         255896 Microsoft.Management.Infrastructure.Native.dll                        
-a----         5/5/2020   1:07 AM         984992 Microsoft.PowerShell.GraphicalHost.dll                                
-a----         5/5/2020   1:07 AM         141728 Microsoft.PowerShell.SDK.dll                                          
-a----         5/5/2020   1:07 AM          21392 Microsoft.Win32.Registry.AccessControl.dll                            
-a----         5/5/2020   1:07 AM          97168 Microsoft.Win32.Registry.dll                                          
-a----         5/5/2020   1:07 AM          80800 Microsoft.Win32.SystemEvents.dll                                      
-a----         5/5/2020   1:07 AM         143760 Namotion.Reflection.dll                                               
-a----         5/5/2020   1:07 AM        1848224 Newtonsoft.Json.dll                                                   
-a----         5/5/2020   1:07 AM         615840 NJsonSchema.dll                                                       
-a----         5/5/2020   1:07 AM         477600 System.CodeDom.dll                                                    
-a----         5/5/2020   1:07 AM         186256 System.Collections.Concurrent.dll                                     
-a----         5/5/2020   1:07 AM         327056 System.Collections.dll                                                
-a----         5/5/2020   1:07 AM          91552 System.Collections.Specialized.dll                                    
-a----         5/5/2020   1:07 AM         722776 System.ComponentModel.Composition.dll                                 
-a----         5/5/2020   1:07 AM          95136 System.ComponentModel.Composition.Registration.dll                    
-a----         5/5/2020   1:07 AM         977312 System.Configuration.ConfigurationManager.dll                         
-a----         5/5/2020   1:07 AM         150432 System.Console.dll                                                    
-a----         5/5/2020   1:07 AM         608144 System.Data.Odbc.dll                                                  
-a----         5/5/2020   1:07 AM         850312 System.Data.OleDb.dll                                                 
-a----         5/5/2020   1:07 AM        2537872 System.Data.SqlClient.dll                                             
-a----         5/5/2020   1:07 AM         301456 System.Diagnostics.EventLog.dll                                       
-a----         5/5/2020   1:07 AM          30112 System.Diagnostics.FileVersionInfo.dll                                
-a----         5/5/2020   1:07 AM         267152 System.Diagnostics.PerformanceCounter.dll                             
-a----         5/5/2020   1:07 AM         267152 System.Diagnostics.Process.dll                                        
-a----         5/5/2020   1:07 AM         723352 System.DirectoryServices.AccountManagement.dll                        
-a----         5/5/2020   1:07 AM        1027472 System.DirectoryServices.dll                                          
-a----         5/5/2020   1:07 AM         274848 System.DirectoryServices.Protocols.dll                                
-a----         5/5/2020   1:07 AM         966552 System.Drawing.Common.dll                                             
-a----         5/5/2020   1:07 AM         127376 System.IO.FileSystem.AccessControl.dll                                
-a----         5/5/2020   1:07 AM         218000 System.IO.FileSystem.dll                                              
-a----         5/5/2020   1:07 AM         271264 System.IO.Packaging.dll                                               
-a----         5/5/2020   1:07 AM         134552 System.IO.Pipes.dll                                                   
-a----         5/5/2020   1:07 AM         146840 System.IO.Ports.dll                                                   
-a----         5/5/2020   1:07 AM         422288 System.Linq.dll                                                       
-a----         5/5/2020   1:07 AM        5247384 System.Linq.Expressions.dll                                           
-a----         5/5/2020   1:07 AM         844184 System.Management.dll                                                 
-a----         5/5/2020   1:07 AM         265632 System.Net.Http.WinHttpHandler.dll                                    
-a----         5/5/2020   1:07 AM        5483928 System.Private.ServiceModel.dll                                       
-a----         5/5/2020   1:07 AM         236440 System.Private.Uri.dll                                                
-a----         5/5/2020   1:07 AM         194448 System.Reflection.Context.dll                                         
-a----         5/5/2020   1:07 AM         197016 System.Runtime.Caching.dll                                            
-a----         5/5/2020   1:07 AM          19352 System.Runtime.CompilerServices.Unsafe.dll                            
-a----         5/5/2020   1:07 AM          17296 System.Runtime.Extensions.dll                                         
-a----         5/5/2020   1:07 AM         229280 System.Security.AccessControl.dll

Signing after the change.

NOTE 1: if the origin starts signing the file, this code will automatically stop signing the binary.
NOTE 2: some of these files are crossgen'ed for performance and the signature is lost. See the list of crossgen'ed binaries below.

subject                                                                                              path
-------                                                                                              ----
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Console.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Newtonsoft.Json.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US NJsonSchema.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Security.Cryptography.Pkcs.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Management.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Security.Cryptography.ProtectedData.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Security.Cryptography.Xml.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Security.Permissions.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Security.Principal.Windows.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Linq.Expressions.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Linq.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.IO.Ports.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Private.ServiceModel.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.IO.Packaging.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.ServiceModel.Syndication.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.ServiceProcess.ServiceController.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Text.Encoding.CodePages.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Text.Encodings.Web.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Security.Cryptography.Cng.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.IO.FileSystem.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Net.Http.WinHttpHandler.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Namotion.Reflection.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Reflection.Context.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.Management.Infrastructure.Native.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.Management.Infrastructure.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.CSharp.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.CodeAnalysis.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.CodeAnalysis.CSharp.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.ApplicationInsights.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Markdig.Signed.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.PowerShell.GraphicalHost.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Configuration.ConfigurationManager.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.PowerShell.SDK.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Runtime.Caching.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Runtime.CompilerServices.Unsafe.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Runtime.Extensions.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.Win32.Registry.AccessControl.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.Win32.Registry.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US Microsoft.Win32.SystemEvents.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Security.AccessControl.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Threading.AccessControl.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.IO.Pipes.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Threading.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Collections.Concurrent.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Windows.Extensions.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.DirectoryServices.Protocols.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.DirectoryServices.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.DirectoryServices.AccountManagement.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Collections.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.IO.FileSystem.AccessControl.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Collections.Specialized.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Diagnostics.Process.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Diagnostics.PerformanceCounter.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Diagnostics.FileVersionInfo.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Diagnostics.EventLog.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.ComponentModel.Composition.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.ComponentModel.Composition.Registration.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Data.SqlClient.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Data.OleDb.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Data.Odbc.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Drawing.Common.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.CodeDom.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Private.Uri.dll
CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US System.Threading.Tasks.Parallel.dll

Here is the full file signature manifest

signatures.txt

CrossGen'ed binaries

        "Microsoft.CodeAnalysis.CSharp.dll"
        "Microsoft.CodeAnalysis.dll"
        "System.Linq.Expressions.dll"
        "Microsoft.CSharp.dll"
        "System.Runtime.Extensions.dll"
        "System.Linq.dll"
        "System.Collections.Concurrent.dll"
        "System.Collections.dll"
        "Newtonsoft.Json.dll"
        "System.IO.FileSystem.dll"
        "System.Diagnostics.Process.dll"
        "System.Threading.Tasks.Parallel.dll"
        "System.Security.AccessControl.dll"
        "System.Text.Encoding.CodePages.dll"
        "System.Private.Uri.dll"
        "System.Threading.dll"
        "System.Security.Principal.Windows.dll"
        "System.Console.dll"
        "Microsoft.Win32.Registry.dll"
        "System.IO.Pipes.dll"
        "System.Diagnostics.FileVersionInfo.dll"
        "System.Collections.Specialized.dll"
        "Microsoft.ApplicationInsights.dll"

PR Checklist

@TravisEz13 TravisEz13 added Compliance Related to compliance requirements CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels May 5, 2020
@ghost ghost assigned iSazonov May 5, 2020
@TravisEz13 TravisEz13 added this to the 7.0.x-Servicing-Consider milestone May 5, 2020
@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned iSazonov May 5, 2020
@TravisEz13
Copy link
Member Author

TravisEz13 commented May 5, 2020

merging early to avoid conflicts with other works

@TravisEz13 TravisEz13 changed the title Update the release build to sign any unsigned files as 3rd party binaries Update the build to sign any unsigned files as 3rd party Dlls May 5, 2020
@TravisEz13 TravisEz13 merged commit ab65ac9 into PowerShell:master May 5, 2020
@TravisEz13 TravisEz13 deleted the sign-everythnig branch May 5, 2020 19:35
@ghost
Copy link

ghost commented May 19, 2020

🎉v7.1.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 19, 2020
Closed
@ghost
Copy link

ghost commented Jun 11, 2020

🎉v6.2.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jun 11, 2020

🎉v7.0.2 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Jun 11, 2020
Merged
Merged
Merged
Merged
Closed
Closed
silijon pushed a commit to SkyKick/PowerShell that referenced this pull request Jul 2, 2020
@TravisEz13
Update the build to sign any unsigned files as 3rd party Dlls (PowerS…
26b972a 
…hell#12581)
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Compliance Related to compliance requirements

Projects

None yet

Milestone

6.2.6

Development

Successfully merging this pull request may close these issues.

Feature Request: Sign any of the unsigned binaries

3 participants

@TravisEz13 @adityapatwardhan @iSazonov