Skip to content

Bump .NET to 5.0.0-preview.4 #12507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 3 commits into from
Apr 28, 2020
Merged

Bump .NET to 5.0.0-preview.4 #12507

daxian-dbw merged 3 commits into from
Apr 28, 2020

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Apr 27, 2020 •
edited
Loading

PR Summary

Bump to the latest version of .NET 5.0.0-preview.4 pre-release version.

PR Context

Update to the latest SDK and packages from 5.0.0-preview.4

PR Checklist

@ghost ghost assigned anmenaga Apr 27, 2020
PoshChan
PoshChan reviewed Apr 27, 2020
View reviewed changes
PoshChan
PoshChan reviewed Apr 27, 2020
View reviewed changes
@adityapatwardhan
Copy link
Member Author

adityapatwardhan commented Apr 27, 2020

@PoshChan please retry windows

@PoshChan
Copy link
Collaborator

PoshChan commented Apr 27, 2020

@adityapatwardhan, successfully started retry of PowerShell-CI-Windows

PoshChan
PoshChan reviewed Apr 27, 2020
View reviewed changes
@daxian-dbw
Copy link
Member

daxian-dbw commented Apr 28, 2020

@PoshChan please retry windows

@PoshChan
Copy link
Collaborator

PoshChan commented Apr 28, 2020

@daxian-dbw, successfully started retry of PowerShell-CI-Windows

PoshChan
PoshChan reviewed Apr 28, 2020
View reviewed changes
@adityapatwardhan
Copy link
Member Author

adityapatwardhan commented Apr 28, 2020

@daxian-dbw I am adding the new assembly to the allowed list. On a local build here is what is see:

PS> [System.AppDomain]::CurrentDomain.GetAssemblies() | sls 'System.Security.Principal' -SimpleMatch

System.Security.Principal.Windows, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
System.Security.Principal, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a

@huzefaMD

This comment has been minimized.

Sign in to view
@daxian-dbw
Copy link
Member

daxian-dbw commented Apr 28, 2020

@adityapatwardhan That looks fine to me. We will see how that goes after this PR is merged.

@adityapatwardhan
Copy link
Member Author

adityapatwardhan commented Apr 28, 2020

@daxian-dbw Ready for merge?

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 28, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.3 milestone Apr 28, 2020
@TravisEz13
Copy link
Member

TravisEz13 commented Apr 28, 2020

@PoshChan please rerun windows

@PoshChan
Copy link
Collaborator

PoshChan commented Apr 28, 2020

@TravisEz13, successfully started rebuild of PowerShell-CI-Windows

@TravisEz13
Copy link
Member

TravisEz13 commented Apr 28, 2020

I think there is a conflict with another PR....

@daxian-dbw
Copy link
Member

daxian-dbw commented Apr 28, 2020 •
edited by unfurl-links bot
Loading

@adityapatwardhan is preview.4 released? I cannot find it at the official site https://dotnet.microsoft.com/download/dotnet/5.0

Microsoft
.NET 5.0 downloads for Linux, macOS, and Windows. .NET is a cross-platform version of .NET, for building apps that run on Linux, macOS, and Windows.

@daxian-dbw daxian-dbw merged commit cc0d20a into PowerShell:master Apr 28, 2020
@adityapatwardhan adityapatwardhan changed the title Bump .NET to 5.0.0-preview.4 WIP: Bump .NET to 5.0.0-preview.4 Apr 28, 2020
@adityapatwardhan adityapatwardhan changed the title WIP: Bump .NET to 5.0.0-preview.4 Bump .NET to 5.0.0-preview.4 Apr 28, 2020
@adityapatwardhan adityapatwardhan deleted the UpdateDotnetP4 branch April 28, 2020 21:18
@ghost
Copy link

ghost commented May 19, 2020

🎉v7.1.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.3

Development

Successfully merging this pull request may close these issues.

7 participants

@adityapatwardhan @PoshChan @daxian-dbw @huzefaMD @TravisEz13 @iSazonov @anmenaga