Use new TFM net5.0. Step 2 #12503
Use new TFM net5.0. Step 2 #12503
Conversation
iSazonov
added
the
CL-BuildPackaging
iSazonov
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
|
|
||
| <PropertyGroup> | ||
| <Product>PowerShell</Product> | ||
| <Company>Microsoft Corporation</Company> |
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-macos
Test-Connection.TraceRoute.TraceRoute works
Expected exactly '127.0.0.1', but got 10.79.8.80.
at <ScriptBlock>, /Users/runner/runners/2.166.4/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 258
258: $result[0].TargetAddress | Should -BeExactly $realAddress
|
@iSazonov Thanks for this PR. I was working on the same fixes. |
|
@PoshChan please retry macOs |
|
@adityapatwardhan, successfully started retry of |
| [string] $PackageRuntimesFolder, | ||
|
|
||
| [Parameter(Mandatory = $true)] | ||
| [string] $PlatformBinPath |
There was a problem hiding this comment.
perhaps we should have one place where we define this in this script?
There was a problem hiding this comment.
@TravisEz13 Please re-review. Pushed changes to use a variable.
|
|
||
| <PropertyGroup> | ||
| <Product>PowerShell</Product> | ||
| <Company>Microsoft Corporation</Company> |
There was a problem hiding this comment.
@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By Process Id.Can enter using NamedPipeConnectionInfo
Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 148
148: Should -BeTrue -Because (get-content $splat.FilePath -Raw)
|
@PoshChan please retry windows |
|
@adityapatwardhan, successfully started retry of |
|
@TravisEz13 please re-review |
follow-up to PowerShell#12503
|
🎉 Handy links: |
4 participants
PR Summary
Migrate to new TFM "net5.0".
Continue #12486
I don't still understand how we should build packages in right way. Perhaps we will have fix this in later.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.