Skip to content

Update dotnet metadata for next channel for automated updates #12502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 4 commits into from
Apr 29, 2020
+7 −2
Merged

Update dotnet metadata for next channel for automated updates #12502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94e9708
Update dotnet metadata for next channel for automated updates
adityapatwardhan Apr 23, 2020
78c6412
Add ability to override with SDK version
adityapatwardhan Apr 27, 2020
66f8680
Merge branch 'master' into DotNetAutoUpdate
adityapatwardhan Apr 28, 2020
18a6bd3
Update DotnetRuntimeMetadata.json
TravisEz13 Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DotnetRuntimeMetadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
Copy link
Collaborator

@PoshChan PoshChan Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By Process Id.Can enter using NamedPipeConnectionInfo

Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 148
148:                     Should -BeTrue -Because (get-content $splat.FilePath -Raw)

"sdk": {
"channel": "release/5.0.1xx-preview4",
"packageVersionPattern": "5.0.0-preview.4"
"packageVersionPattern": "5.0.0-preview.4",
"nextChannel": "net5/preview4"
}
}
6 changes: 5 additions & 1 deletion tools/UpdateDotnetRuntime.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

[CmdletBinding()]
param (
[Parameter()]
[string]$SDKVersionOverride
)

<#
Expand Down Expand Up @@ -139,7 +141,9 @@ if(-not (Get-PackageSource -Name 'dotnet5' -ErrorAction SilentlyContinue))

## Install latest version from the channel

Install-Dotnet -Channel "$Channel" -Version 'latest'
$sdkVersion = if ($SDKVersionOverride) { $SDKVersionOverride } else { "latest" }

Install-Dotnet -Channel "$Channel" -Version $sdkVersion

Write-Verbose -Message "Installing .NET SDK completed." -Verbose

Expand Down