Update dotnet metadata for next channel for automated updates #12502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
PoshChan
reviewed
Apr 27, 2020
DotnetRuntimeMetadata.json
Outdated
Collaborator
There was a problem hiding this comment.
@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By Process Id.Can enter using NamedPipeConnectionInfo
Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 148
148: Should -BeTrue -Because (get-content $splat.FilePath -Raw)
adityapatwardhan
force-pushed
the
DotNetAutoUpdate
branch
from
561739d to
78c6412
Compare
adityapatwardhan
requested review from
TravisEz13,
anmenaga and
daxian-dbw
as code owners
TravisEz13
approved these changes
Apr 27, 2020
Member
Author
|
@daxian-dbw Ready for merge? |
Member
|
@adityapatwardhan there is a conflict |
Member
Author
|
@TravisEz13 Merge conflict is resolved now |
TravisEz13
reviewed
Apr 28, 2020
adityapatwardhan
added
the
CL-BuildPackaging
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add more metadata for enabling auto updates.
PR Context
The meta data is used by an Azure function to check if an update is needed to the .NET SDK using the .\tools\UpdateDotnetRuntime.ps1 script.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.