Skip to content

Conversation

@PaulHigin
Copy link
Contributor

PR Summary

This PR fixes a bug where a null reference exception is thrown during Start-Job, if default Windows PowerShell default shell Id is not in the registry.

PR Context

Some Azure images have run into this problem where Start-Job fails even when running in pwsh child process rather than Windows PowerShell child. Fix is to guard against the missing registry entry.

PR Checklist

@ghost ghost assigned iSazonov Apr 10, 2020
@PaulHigin PaulHigin added WG-Remoting PSRP issues with any transport layer Issue-Bug Issue has been identified as a bug in the product labels Apr 10, 2020
@PaulHigin PaulHigin added this to the 7.0.x-Servicing-Consider milestone Apr 10, 2020
@PaulHigin PaulHigin requested a review from SteveL-MSFT April 10, 2020 16:55
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 11, 2020
@iSazonov
Copy link
Collaborator

Oh, when do we start doing null annotations? Up to 80% of .Net Runtime code is already annotated and we can benefit from this.

@iSazonov iSazonov merged commit 9a92c62 into PowerShell:master Apr 14, 2020
@PaulHigin PaulHigin deleted the fix-startjob-nowinpwsh branch April 14, 2020 15:14
@TravisEz13 TravisEz13 modified the milestones: 7.0.1-approved, 7.0.1 Apr 20, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

🎉v7.1.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented May 14, 2020

🎉v7.0.1 has been released which incorporates this pull request.:tada:

Handy links:

silijon pushed a commit to SkyKick/PowerShell that referenced this pull request Jul 2, 2020
Some Azure images have run into this problem where Start-Job fails even when running in pwsh child process rather than Windows PowerShell child. Fix is to guard against the missing registry entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Issue-Bug Issue has been identified as a bug in the product WG-Remoting PSRP issues with any transport layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants