Skip to content

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Apr 8, 2020

PR Summary

Script to help to move to the next preview version of .NET. The version of .NET is in DotnetRuntimeMetadata.json.
The script is to be used by developer who wants to move the code base to the new .NET preview. The script will update the global.json and all the other csproj files which need to be updated.

PR Context

PR Checklist

@iSazonov iSazonov added the Area-Maintainers-Build specific to affecting the build label Apr 9, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.2 milestone Apr 9, 2020
@iSazonov iSazonov added CL-Tools Indicates that a PR should be marked as a tools change in the Change Log and removed Area-Maintainers-Build specific to affecting the build labels Apr 9, 2020
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan Can you please update the PR description to include some information about what the script does and the context of why we need it?

@@ -0,0 +1,130 @@
[CmdletBinding()]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this file should be put in tools folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.. I can move it.

@adityapatwardhan
Copy link
Member Author

@daxian-dbw Ping..

$stringToReplace = "<PackageReference Include=`"$($v.Name)`" Version=`"$($v.Version)`" />"
$newString = "<PackageReference Include=`"$($v.Name)`" Version=`"$($v.NewVersion)`" />"

$fileContent = $fileContent -replace $stringToReplace, $newString
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doing a regex replace... maybe it's safer to using .replace()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex replace is turning out to be a bit complicated. Keeping it as is. The intention is to create a PR after the script does the changes. So there will be a code review as a safety net.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 14, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 15, 2020
@adityapatwardhan
Copy link
Member Author

@TravisEz13 please re-review

@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned daxian-dbw Apr 15, 2020
@TravisEz13 TravisEz13 merged commit 60f28bc into PowerShell:master Apr 15, 2020
@adityapatwardhan adityapatwardhan deleted the DotNet5p2 branch April 15, 2020 19:32
@iSazonov
Copy link
Collaborator

/cc @bergmeister for information.

@ghost
Copy link

ghost commented Apr 23, 2020

🎉v7.1.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants