Skip to content

CodeFactor cleanup #12251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 3 commits into from Apr 14, 2020
Merged

CodeFactor cleanup #12251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a5b7ee
Code cleanup
RDIL Apr 3, 2020
4f14209
whoops
RDIL Apr 3, 2020
ad619ca
Update src/Microsoft.Management.Infrastructure.CimCmdlets/CimSessionO…
RDIL Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN apt-get update \
&& apt-get -y install --no-install-recommends apt-utils 2>&1 \
#
# Verify git, process tools, lsb-release (common in install instructions for CLIs) installed
&& apt-get -y install git procps lsb-release \
&& apt-get -y install --no-install-recommends git procps lsb-release \
#
# Clean up
&& apt-get autoremove -y \
Expand Down
15 changes: 7 additions & 8 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimAsyncOperation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ internal abstract class CimAsyncOperation : IDisposable
#region Constructor

/// <summary>
/// Constructor.
/// The constructor.
/// </summary>
public CimAsyncOperation()
{
Expand Down Expand Up @@ -126,7 +126,7 @@ protected void OperationDeletedHandler(object cimSession, OperationEventArgs act
/// </para>
/// </summary>
/// <param name="cmdletOperation">
/// wrapper of cmdlet, <seealso cref="CmdletOperationBase"/> for details.
/// Wrapper of cmdlet, <seealso cref="CmdletOperationBase"/> for details.
/// </param>
public void ProcessActions(CmdletOperationBase cmdletOperation)
{
Expand All @@ -146,12 +146,12 @@ public void ProcessActions(CmdletOperationBase cmdletOperation)

/// <summary>
/// <para>
/// process remaining actions until all operations are completed or
/// Process remaining actions until all operations are completed or
/// current cmdlet is terminated by user.
/// </para>
/// </summary>
/// <param name="cmdletOperation">
/// wrapper of cmdlet, <seealso cref="CmdletOperationBase"/> for details.
/// Wrapper of cmdlet, <seealso cref="CmdletOperationBase"/> for details.
/// </param>
public void ProcessRemainActions(CmdletOperationBase cmdletOperation)
{
Expand Down Expand Up @@ -202,7 +202,6 @@ protected bool GetActionAndRemove(out CimBaseAction action)
/// Add temporary <seealso cref="CimSessionProxy"/> object to cache.
/// </para>
/// </summary>
/// <param name="computerName">Computer name of the cimsession.</param>
/// <param name="sessionproxy">Cimsession wrapper object.</param>
protected void AddCimSessionProxy(CimSessionProxy sessionproxy)
{
Expand Down Expand Up @@ -382,7 +381,7 @@ protected object GetBaseObject(object value)
/// </summary>
/// <param name="value"></param>
/// <param name="referenceType">Output the cimtype of the value, either Reference or ReferenceArray.</param>
/// <returns></returns>
/// <returns>The object.</returns>
protected object GetReferenceOrReferenceArrayObject(object value, ref CimType referenceType)
{
PSReference cimReference = value as PSReference;
Expand Down Expand Up @@ -496,7 +495,7 @@ protected virtual void Dispose(bool disposing)

/// <summary>
/// <para>
/// Clean up managed resources
/// Clean up managed resources.
/// </para>
/// </summary>
private void Cleanup()
Expand Down Expand Up @@ -585,7 +584,7 @@ private void Cleanup()
#region protected members
/// <summary>
/// Event to notify ps thread that either a ACK message sent back
/// or a error happened. Currently only used by class
/// or a error happened. Currently only used by
/// <see cref="CimRegisterCimIndication"/>.
/// </summary>
protected ManualResetEventSlim ackedEvent;
Expand Down
8 changes: 4 additions & 4 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimBaseAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ protected XOperationContextBase Context
internal class CimSyncAction : CimBaseAction, IDisposable
{
/// <summary>
/// Constructor.
/// The constructor.
/// </summary>
public CimSyncAction()
{
Expand All @@ -91,7 +91,7 @@ public virtual CimResponseType GetResponse()

/// <summary>
/// <para>
/// Set response result
/// Set the response result.
/// </para>
/// </summary>
internal CimResponseType ResponseType
Expand All @@ -102,7 +102,7 @@ internal CimResponseType ResponseType
/// <summary>
/// <para>
/// Call this method when the action is completed or
/// the operation is terminated
/// the operation is terminated.
/// </para>
/// </summary>
internal virtual void OnComplete()
Expand All @@ -112,7 +112,7 @@ internal virtual void OnComplete()

/// <summary>
/// <para>
/// block current thread.
/// Block current thread.
/// </para>
/// </summary>
protected virtual void Block()
Expand Down
10 changes: 5 additions & 5 deletions src/Microsoft.Management.Infrastructure.CimCmdlets/CimCmdletModuleInitialize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public sealed class CimCmdletsAssemblyInitializer : IModuleAssemblyInitializer
{
/// <summary>
/// <para>
/// constructor
/// The constructor.
/// </para>
/// </summary>
public CimCmdletsAssemblyInitializer()
Expand Down Expand Up @@ -56,18 +56,18 @@ public void OnImport()

/// <summary>
/// <para>
/// CimCmdlet alias entry
/// CimCmdlet alias entry.
/// </para>
/// </summary>
internal sealed class CimCmdletAliasEntry
{
/// <summary>
/// <para>
/// Constructor
/// The constructor.
/// </para>
/// </summary>
/// <param name="name"></param>
/// <param name="value"></param>
/// <param name="name">The entry name.</param>
/// <param name="value">The entry value.</param>
internal CimCmdletAliasEntry(string name, string value)
{
this._name = name;
Expand Down
Loading