Upgrade to .NET 5 Preview 2 - #12250
Conversation
|
Christoph Bergmeister (@bergmeister) You don't update all places. See #12140. |
…via output of Start-PSPacakge again)" This reverts commit 0ae6b3d.
|
Christoph Bergmeister (@bergmeister) Please add in EndProcessing() method of the Send-MailMessage cmdlet. |
|
Good point, I could locally repro and fix it with that. I will add it in a finally block and bring an existing disposal into that finally block as well |
…ssing in a finally block and include another disposal in there as well.
|
Christoph Bergmeister (@bergmeister) can you fix the CodeFactor issue? |
|
Steve Lee (@SteveL-MSFT) OK, done. |
|
PoshChan-Bot (@PoshChan) Rerun Mac |
|
Christoph Bergmeister (@bergmeister), I do not understand the build target(s) |
|
PoshChan-Bot (@PoshChan) Rerun macos |
|
Christoph Bergmeister (@bergmeister), successfully started rebuild of |
|
🎉 Handy links: |
PR Summary
Note: The
files.wxswas updated with the suggested file fromStart-PSPackage.The change in Send-MailMessage was due to test failures and probably due to this bug fix in .Net Core: dotnet/runtime#683
PR Context
https://devblogs.microsoft.com/dotnet/announcing-net-5-0-preview-2/
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.