Skip to content

Allow case insensitive paths for determining PSModulePath #12192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 2 commits into from
Mar 25, 2020
Merged

Allow case insensitive paths for determining PSModulePath #12192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef69896
Allow case insensitive comparison of paths for determining PSModulePath
adityapatwardhan Mar 24, 2020
a3f8bd1
Address codefactor issue
adityapatwardhan Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,7 +1250,7 @@ internal static string GetWindowsPowerShellModulePath()
}
Copy link
Collaborator

@PoshChan PoshChan Mar 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 2 failures in PowerShell-CI-macos
Test-Connection.Ping.Force IPv4 with implicit PingOptions

Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 83
83:             $result[0].Address | Should -BeExactly $realAddress

Test-Connection.TraceRoute.TraceRoute works

Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 257
257:             $result[0].TargetAddress | Should -BeExactly $realAddress

Copy link
Collaborator

@PoshChan PoshChan Mar 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 2 failures in PowerShell-CI-macos
Test-Connection.Ping.Force IPv4 with implicit PingOptions

Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 83
83:             $result[0].Address | Should -BeExactly $realAddress

Test-Connection.TraceRoute.TraceRoute works

Expected exactly '10.79.0.59', but got 127.0.0.1.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 257
257:             $result[0].TargetAddress | Should -BeExactly $realAddress


// PowerShell specific paths including if set in powershell.config.json file we want to exclude
var excludeModulePaths = new HashSet<string> {
var excludeModulePaths = new HashSet<string>(StringComparer.OrdinalIgnoreCase) {
GetPersonalModulePath(),
GetSharedModulePath(),
GetPSHomeModulePath(),
Expand Down