Allow case insensitive paths for determining PSModulePath
#12192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
PoshChan
reviewed
Mar 24, 2020
PoshChan
reviewed
Mar 24, 2020
SteveL-MSFT
approved these changes
Mar 24, 2020
PoshChan
reviewed
Mar 24, 2020
| if (currentModulePath == null) | ||
| { | ||
| return null; | ||
| } |
Collaborator
There was a problem hiding this comment.
@adityapatwardhan, your last commit had 2 failures in PowerShell-CI-macos
Test-Connection.Ping.Force IPv4 with implicit PingOptions
Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 83
83: $result[0].Address | Should -BeExactly $realAddressTest-Connection.TraceRoute.TraceRoute works
Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 257
257: $result[0].TargetAddress | Should -BeExactly $realAddress
iSazonov
approved these changes
Mar 24, 2020
Member
Author
|
@PoshChan please retry macos |
Collaborator
|
@adityapatwardhan, successfully started retry of |
PoshChan
reviewed
Mar 24, 2020
| if (currentModulePath == null) | ||
| { | ||
| return null; | ||
| } |
Collaborator
There was a problem hiding this comment.
@adityapatwardhan, your last commit had 2 failures in PowerShell-CI-macos
Test-Connection.Ping.Force IPv4 with implicit PingOptions
Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 83
83: $result[0].Address | Should -BeExactly $realAddressTest-Connection.TraceRoute.TraceRoute works
Expected exactly '10.79.0.59', but got 127.0.0.1.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 257
257: $result[0].TargetAddress | Should -BeExactly $realAddress
TravisEz13
added
the
CL-Engine
Member
|
@PoshChan Please remind me in one hour |
Collaborator
|
@TravisEz13, I do not understand: Please remind me in one hour Commands available in this repo for you:
|
TravisEz13
changed the title
PSModulePathPSModulePath
|
🎉 Handy links: |
|
🎉 Handy links: |
silijon
pushed a commit
to SkyKick/PowerShell
that referenced
this pull request
Jul 2, 2020
…ll#12192) * Allow case insensitive comparison of paths for determining PSModulePath * Address codefactor issue
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When comparing paths on Windows for determining the PSModulePath, the comparison should be case insensitive.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.